Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

Add v0.23 label to manifests#833

Merged
openshift-merge-robot merged 2 commits into
openshift:mainfrom
nak3:fix-label
Jun 30, 2021
Merged

Add v0.23 label to manifests#833
openshift-merge-robot merged 2 commits into
openshift:mainfrom
nak3:fix-label

Conversation

@nak3
Copy link
Copy Markdown

@nak3 nak3 commented Jun 30, 2021

This patch updates label in manifests to 0.23 for the version mismatch issue by knative-operator.

/cc @markusthoemmes @mgencur

@openshift-ci openshift-ci Bot requested review from markusthoemmes and mgencur June 30, 2021 06:31
@nak3
Copy link
Copy Markdown
Author

nak3 commented Jun 30, 2021

#832 verified this change.
Although test shows fail but it just failure of post job and all e2e tests passed

Copy link
Copy Markdown

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 30, 2021
@openshift-merge-robot openshift-merge-robot merged commit 90b639c into openshift:main Jun 30, 2021
openshift-merge-robot pushed a commit that referenced this pull request Jul 1, 2021
… (#836)

* Add root ca for Controller HA test with https (knative#11471)

This patch adds `test.AddRootCAtoTransport` for prober in TestControllerHA.

* stick serverless-operator branch

* Revert "stick serverless-operator branch"

This reverts commit d2be74a.

* Add v0.23 label to manifests (#833)

* Remove config/domainmapping

* Add 0.23 label

* Update label

* Add back DomainMapping
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants