Skip to content

Bug 2018516: 4.9: bump(github.com/openshift/*): make go.{mod,sum} point to 1.22.1#1026

Closed
sttts wants to merge 1 commit intoopenshift:release-4.9from
sttts:sttts-4.9-1.22.1
Closed

Bug 2018516: 4.9: bump(github.com/openshift/*): make go.{mod,sum} point to 1.22.1#1026
sttts wants to merge 1 commit intoopenshift:release-4.9from
sttts:sttts-4.9-1.22.1

Conversation

@sttts
Copy link
Copy Markdown

@sttts sttts commented Oct 29, 2021

The fake versions in go.{mod,sum} for staging repos pointed to 1.22 rc0. ART depends on those for deriving the version string. This updates them, basically like #950, but pointing to the release-4.9 branches of github.com/openshift/*.

@openshift-ci openshift-ci Bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Oct 29, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 29, 2021

@sttts: This pull request references Bugzilla bug 2018516, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2018516: Update go.{mod,sum} to point to 1.22.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 29, 2021
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Oct 29, 2021
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2021
@openshift-ci-robot
Copy link
Copy Markdown

@sttts: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

@sttts sttts changed the base branch from master to release-4.9 October 29, 2021 21:32
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 29, 2021

@sttts: This pull request references Bugzilla bug 2018516, which is invalid:

  • expected dependent Bugzilla bug 1986003 to target a release in 4.10.0, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2018516: Update go.{mod,sum} to point to 1.22.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2021
@openshift-ci openshift-ci Bot requested review from deads2k and mfojtik October 29, 2021 21:32
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2021
@sttts
Copy link
Copy Markdown
Author

sttts commented Oct 29, 2021

/bugzilla refresh

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 29, 2021

@sttts: This pull request references Bugzilla bug 2018516, which is invalid:

  • expected dependent Bugzilla bug 1986003 to target a release in 4.10.0, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts sttts changed the title Bug 2018516: Update go.{mod,sum} to point to 1.22.1 Bug 2018516: 4.9: Update go.{mod,sum} to point to 1.22.1 Oct 29, 2021
@sttts sttts removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Oct 29, 2021
@sttts
Copy link
Copy Markdown
Author

sttts commented Oct 29, 2021

/hold

The k8s.io/kubernetes line in go.sum is still wrong. No idea where it comes from (note: it does not matter, just cosmetics, but maybe relevant for ART).

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2021
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Oct 29, 2021
@openshift-ci-robot
Copy link
Copy Markdown

@sttts: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link
Copy Markdown

@sttts: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link
Copy Markdown

@sttts: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci openshift-ci Bot added the vendor-update Touching vendor dir or related files label Oct 29, 2021
@openshift-ci-robot
Copy link
Copy Markdown

@sttts: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@sttts
Copy link
Copy Markdown
Author

sttts commented Nov 1, 2021

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Nov 1, 2021

@sttts: This pull request references Bugzilla bug 2018516, which is invalid:

  • expected dependent Bugzilla bug 1986003 to target a release in 4.10.0, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@tkashem
Copy link
Copy Markdown

tkashem commented Nov 1, 2021

/retest

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

…nt to 1.22.1

The referenced dependencies were pointing to rc0. Hence, kube's go.mod was too.
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2021
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Nov 1, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Nov 1, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link
Copy Markdown

@sttts: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@sttts sttts added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 1, 2021
@sttts
Copy link
Copy Markdown
Author

sttts commented Nov 1, 2021

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Nov 1, 2021

@sttts: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/artifacts 0e0b0f7565460acdaa2acdb384efc34b8ba9d79e link true /test artifacts
ci/prow/e2e-openstack-csi-manila 56f0a6a link false /test e2e-openstack-csi-manila
ci/prow/e2e-agnostic-cmd 56f0a6a link false /test e2e-agnostic-cmd
ci/prow/e2e-aws-fips 56f0a6a link true /test e2e-aws-fips
ci/prow/e2e-openstack-csi-cinder 56f0a6a link false /test e2e-openstack-csi-cinder
ci/prow/k8s-e2e-gcp-five-control-plane-replicas 56f0a6a link true /test k8s-e2e-gcp-five-control-plane-replicas

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@s-urbaniak
Copy link
Copy Markdown

/close #1030 got merged faster

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Nov 2, 2021

@sttts: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2021
@s-urbaniak
Copy link
Copy Markdown

/close

@openshift-ci openshift-ci Bot closed this Nov 2, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Nov 2, 2021

@s-urbaniak: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Nov 2, 2021

@sttts: This pull request references Bugzilla bug 2018516. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 2018516: 4.9: bump(github.com/openshift/*): make go.{mod,sum} point to 1.22.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants