Skip to content

OCPBUGS-4658: Apply shared defaulters to CRD-based routes.#1440

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
benluddy:release-4.13-routev1-admission-defaults
Dec 14, 2022
Merged

OCPBUGS-4658: Apply shared defaulters to CRD-based routes.#1440
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
benluddy:release-4.13-routev1-admission-defaults

Conversation

@benluddy
Copy link
Copy Markdown

@benluddy benluddy commented Dec 13, 2022

This addresses the known remaining API disparities between CRD-based and openshift-apiserver-based Routes.

Proof PR: openshift/microshift#1192.

@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 13, 2022
@openshift-ci-robot
Copy link
Copy Markdown

@benluddy: This pull request references Jira Issue OCPBUGS-4658, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This addresses the known remaining API disparities between CRD-based and openshift-apiserver-based Routes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown

@benluddy: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci Bot requested review from deads2k, jogeo and sttts December 13, 2022 16:35
@openshift-ci openshift-ci Bot added the vendor-update Touching vendor dir or related files label Dec 13, 2022
@openshift-ci-robot
Copy link
Copy Markdown

@benluddy: This pull request references Jira Issue OCPBUGS-4658, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

Details

In response to this:

This addresses the known remaining API disparities between CRD-based and openshift-apiserver-based Routes.

Proof PR: openshift/microshift#1192.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@benluddy benluddy force-pushed the release-4.13-routev1-admission-defaults branch from 3ebdf49 to 8e13d39 Compare December 13, 2022 18:53
@openshift-ci-robot
Copy link
Copy Markdown

@benluddy: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@benluddy
Copy link
Copy Markdown
Author

/test unit

@tkashem
Copy link
Copy Markdown

tkashem commented Dec 13, 2022

/test 4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade

@tkashem
Copy link
Copy Markdown

tkashem commented Dec 13, 2022

/lgtm
/cc @sanchezl

@openshift-ci openshift-ci Bot requested a review from sanchezl December 13, 2022 23:12
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2022
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 14, 2022

@benluddy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade 8e13d39 link false /test 4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Copy Markdown

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, soltysh, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2022
@soltysh
Copy link
Copy Markdown

soltysh commented Dec 14, 2022

/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci openshift-ci Bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Dec 14, 2022
@openshift-merge-robot openshift-merge-robot merged commit 0003605 into openshift:master Dec 14, 2022
@openshift-ci-robot
Copy link
Copy Markdown

@benluddy: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4658 has been moved to the MODIFIED state.

Details

In response to this:

This addresses the known remaining API disparities between CRD-based and openshift-apiserver-based Routes.

Proof PR: openshift/microshift#1192.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants