UPSTREAM: 115863: Remove global framework variable#1480
Conversation
`f framework.Framework` does not need to be global, it's used only on a few places. This fixes vSphereDriver.PrepareTest() in in_tree.go that schedules ginkgo.DeferCleanup() that uses the global `f` variable, but its value is not valid at the time of ginkgo cleanup.
openshift-ci-robot
added
the
backports/unvalidated-commits
|
@sanchezl: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/test e2e-vsphere |
soltysh
left a comment
soltysh
left a comment
There was a problem hiding this comment.
Upstream is tagged and in the merge queue
/lgtm
/approve
/remove-label backports/unvalidated-commits
/label backports/validated-commits
openshift-ci
Bot
added
backports/validated-commits
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sanchezl, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@sanchezl: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
6 participants
f framework.Frameworkdoes not need to be global, it's used only on a fewplaces.
This fixes vSphereDriver.PrepareTest() in in_tree.go that schedules
ginkgo.DeferCleanup() that uses the global
fvariable, but its value is notvalid at the time of ginkgo cleanup.