Skip to content

Bug 1965545: vendor: bump runc to rc95 + "unit exists" fix#790

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
kolyshkin:ocp-4.8-runc-fix-unit-exists
Jun 9, 2021
Merged

Bug 1965545: vendor: bump runc to rc95 + "unit exists" fix#790
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
kolyshkin:ocp-4.8-runc-fix-unit-exists

Conversation

@kolyshkin
Copy link
Copy Markdown

What type of PR is this?

/kind bug

/kind regression

What this PR does / why we need it:

This updates runc/libcontainer vendoring to include the fix from from openshift/opencontainers-runc#9 (which in turn is a backport from opencontainers/runc#2997).

Which issue(s) this PR fixes:

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1965545

Special notes for your reviewer:

Fix the "Pod stuck in ContainerCreating: Unit ...slice already exists" regression

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 8, 2021

@kolyshkin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

vendor: bump runc to rc95 + "unit exists" fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 8, 2021

@kolyshkin: The label(s) kind/regression cannot be applied, because the repository doesn't have them.

Details

In response to this:

What type of PR is this?

/kind bug

/kind regression

What this PR does / why we need it:

This updates runc/libcontainer vendoring to include the fix from from openshift/opencontainers-runc#9 (which in turn is a backport from opencontainers/runc#2997).

Which issue(s) this PR fixes:

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1965545

Special notes for your reviewer:

Fix the "Pod stuck in ContainerCreating: Unit ...slice already exists" regression

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jun 8, 2021
@openshift-ci openshift-ci Bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 8, 2021
@openshift-ci-robot
Copy link
Copy Markdown

@kolyshkin: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@kolyshkin kolyshkin changed the title vendor: bump runc to rc95 + "unit exists" fix Bug 1965545: vendor: bump runc to rc95 + "unit exists" fix Jun 8, 2021
@openshift-ci openshift-ci Bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 8, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 8, 2021

@kolyshkin: This pull request references Bugzilla bug 1965545, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead
  • expected Bugzilla bug 1965545 to depend on a bug targeting a release in 4.9.0 and in one of the following states: MODIFIED, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1965545: vendor: bump runc to rc95 + "unit exists" fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from marun and mfojtik June 8, 2021 01:09
@nee1esh
Copy link
Copy Markdown

nee1esh commented Jun 8, 2021

/bugzilla refresh

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 8, 2021

@nee1esh: This pull request references Bugzilla bug 1965545, which is invalid:

  • expected Bugzilla bug 1965545 to depend on a bug targeting a release in 4.9.0 and in one of the following states: MODIFIED, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nee1esh
Copy link
Copy Markdown

nee1esh commented Jun 8, 2021

/retest

@kolyshkin kolyshkin force-pushed the ocp-4.8-runc-fix-unit-exists branch from ea29f32 to 138bc93 Compare June 8, 2021 03:21
@openshift-ci-robot
Copy link
Copy Markdown

@kolyshkin: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@kolyshkin
Copy link
Copy Markdown
Author

/retest

@kolyshkin kolyshkin changed the base branch from release-4.8 to master June 8, 2021 18:48
@openshift-ci openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 8, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 8, 2021

@kolyshkin: This pull request references Bugzilla bug 1965545, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

Details

In response to this:

Bug 1965545: vendor: bump runc to rc95 + "unit exists" fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 8, 2021
@deads2k
Copy link
Copy Markdown

deads2k commented Jun 8, 2021

need to make this an UPSTREAM: commit. We will drop this commit in 4.9 when updating to 1.22

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin force-pushed the ocp-4.8-runc-fix-unit-exists branch from 138bc93 to 3b7f326 Compare June 8, 2021 18:56
@openshift-ci-robot
Copy link
Copy Markdown

@kolyshkin: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@deads2k
Copy link
Copy Markdown

deads2k commented Jun 8, 2021

This is ok if the node team acks it.

/approve
/assign @mrunalp

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2021
@mrunalp
Copy link
Copy Markdown
Member

mrunalp commented Jun 8, 2021

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, kolyshkin, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrunalp
Copy link
Copy Markdown
Member

mrunalp commented Jun 8, 2021

/retest

@mrunalp mrunalp removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jun 8, 2021
@kolyshkin
Copy link
Copy Markdown
Author

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 9, 2021

@kolyshkin: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi 138bc93c1efd3abba9c9ac28ac79502beaa99770 link /test e2e-metal-ipi
ci/prow/e2e-metal-ipi-ovn-ipv6 138bc93c1efd3abba9c9ac28ac79502beaa99770 link /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-single-node 138bc93c1efd3abba9c9ac28ac79502beaa99770 link /test e2e-aws-single-node
ci/prow/e2e-metal-ipi-ovn-dualstack 138bc93c1efd3abba9c9ac28ac79502beaa99770 link /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-aws-disruptive 138bc93c1efd3abba9c9ac28ac79502beaa99770 link /test e2e-aws-disruptive
ci/prow/e2e-aws-downgrade 138bc93c1efd3abba9c9ac28ac79502beaa99770 link /test e2e-aws-downgrade
ci/prow/e2e-aws-upgrade 138bc93c1efd3abba9c9ac28ac79502beaa99770 link /test e2e-aws-upgrade
ci/prow/configmap-scale 138bc93c1efd3abba9c9ac28ac79502beaa99770 link /test configmap-scale

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1ed5f64 into openshift:master Jun 9, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 9, 2021

@kolyshkin: All pull requests linked via external trackers have merged:

Bugzilla bug 1965545 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1965545: vendor: bump runc to rc95 + "unit exists" fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants