Skip to content

Detect unused test-annotating rules#830

Closed
danwinship wants to merge 2 commits intoopenshift:masterfrom
danwinship:detect-unused-rules
Closed

Detect unused test-annotating rules#830
danwinship wants to merge 2 commits intoopenshift:masterfrom
danwinship:detect-unused-rules

Conversation

@danwinship
Copy link
Copy Markdown

I was trying to figure out if any of the current networking-related test annotations were out of date and ended up doing this. FTR:

Unused pattern: [Disabled:Alpha] => \[Feature:CSIServiceAccountToken\]
Unused pattern: [Disabled:Broken] => ServiceAccounts should support OIDC discovery of service account issuer
Unused pattern: [Disabled:Broken] => recreate nodes and ensure they function upon restart
Unused pattern: [Disabled:Broken] => should reject a Pod requesting a RuntimeClass with conflicting node selector
Unused pattern: [Disabled:SpecialConfig] => Advanced Audit should audit API calls
Unused pattern: [Disabled:SpecialConfig] => \[Feature:Audit\]
Unused pattern: [Disabled:SpecialConfig] => \[Feature:ImageQuota\]
Unused pattern: [Disabled:SpecialConfig] => \[sig-cloud-provider-gcp\]
Unused pattern: [Disabled:SpecialConfig] => should check if Kubernetes master services is included in cluster-info
Unused pattern: [Disabled:Unimplemented] => Kubernetes Dashboard
Unused pattern: [Disabled:Unimplemented] => Ubernetes
Unused pattern: [Disabled:Unimplemented] => kube-ui
Unused pattern: [Disabled:Unimplemented] => should proxy to cadvisor
Unused pattern: [Flaky] => \[Feature:HPA\] Horizontal pod autoscaling \(scale resource: CPU\) \[sig-autoscaling\] ReplicationController light Should scale from 1 pod to 2 pods
Unused pattern: [Serial] => DynamicProvisioner should test that deleting a claim before the volume is provisioned deletes the volume
Unused pattern: [Serial] => Should be able to support the 1\.7 Sample API Server using the current Aggregator
Unused pattern: [Serial] => \[Feature:HPA\] Horizontal pod autoscaling \(scale resource: CPU\) \[sig-autoscaling\] ReplicationController light Should scale from 1 pod to 2 pods
Unused pattern: [Serial] => \[Feature:Performance\]
Unused pattern: [Serial] => \[sig-network\] IngressClass \[Feature:Ingress\] should set default value on new IngressClass
Unused pattern: [Serial] => should prevent Ingress creation if more than 1 IngressClass marked as default
Unused pattern: [Skipped:gce] => \[k8s.io\] \[sig-node\] crictl should be able to run crictl on the node
Unused pattern: [Skipped:gce] => \[sig-api-machinery\] AdmissionWebhook should be able to deny pod and configmap creation
Unused pattern: [Skipped:gce] => \[sig-storage\] CSI Volumes CSI Topology test using GCE PD driver \[Serial\]
Unused pattern: [Skipped:gce] => \[sig-storage\] Detaching volumes should not work when mount is in progress
Unused pattern: [Slow] => \[sig-scalability\]
Unused pattern: [sig-arch] => \[Feature:GKELocalSSD\]
Unused pattern: [sig-arch] => \[Feature:GKENodePool\]
Unused pattern: [sig-cluster-lifecycle] => Feature:ClusterAutoscalerScalability
Unused pattern: [sig-cluster-lifecycle] => recreate nodes and ensure they function
Unused pattern: [sig-node] => Downward API should create a pod that prints his name and namespace
Unused pattern: [sig-node] => Liveness liveness pods should be automatically restarted
Unused pattern: [sig-node] => NodeLease
Unused pattern: [sig-node] => Pods should delete a collection of pods
Unused pattern: [sig-node] => Pods should run through the lifecycle of Pods and PodStatus
Unused pattern: [sig-node] => Probing container
Unused pattern: [sig-node] => Secret should create a pod that reads a secret
Unused pattern: [sig-node] => Security Context When creating a
Unused pattern: [sig-node] => \[NodeAlphaFeature
Unused pattern: [sig-node] => \[NodeConformance\]
Unused pattern: [sig-node] => \[NodeFeature
Unused pattern: [sig-node] => lease API

(note that in some cases, like a lot of the sig-node tests, the pattern is unused because the test got correctly annotated upstream (and so the rule is no longer necessary) not because the test got deleted/renamed)

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jun 25, 2021
@openshift-ci-robot
Copy link
Copy Markdown

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 25, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danwinship
To complete the pull request process, please assign marun after the PR has been reviewed.
You can assign the PR to them by writing /assign @marun in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from marun and sttts June 25, 2021 15:29
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 25, 2021

@danwinship: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify-commits 528c6a3 link /test verify-commits
ci/prow/verify 528c6a3 link /test verify
ci/prow/k8s-e2e-gcp 528c6a3 link /test k8s-e2e-gcp
ci/prow/e2e-gcp 528c6a3 link /test e2e-gcp
ci/prow/e2e-gcp-upgrade 528c6a3 link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 24, 2021
@openshift-bot
Copy link
Copy Markdown

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 24, 2021
@openshift-bot
Copy link
Copy Markdown

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci Bot closed this Nov 23, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Nov 23, 2021

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants