BUILD-281: bump(*): openshift/api; update feature flag unit tests#1201
Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom Sep 29, 2021
Merged
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
gabemontero
changed the title
gabemontero
force-pushed
the
bld-csi-vol-mnt-cfg-ocm
branch
2 times, most recently
from
783d3fd to
8565ba1
Compare
gabemontero
commented
Sep 10, 2021
|
|
||
| replace vbom.ml/util => github.com/fvbommel/util v0.0.0-20180919145318-efcd4e0f9787 | ||
|
|
||
| replace github.com/openshift/api => github.com/gabemontero/api v0.0.0-20210910154316-eaa29e1f16df |
Contributor
Author
There was a problem hiding this comment.
this captures the latest state of openshift/api#1007
when that merges, we'll just change the version for openshift/api up above
This was referenced Sep 10, 2021
openshift-ci
Bot
added
the
needs-rebase
gabemontero
force-pushed
the
bld-csi-vol-mnt-cfg-ocm
branch
from
8565ba1 to
541dce8
Compare
openshift-ci
Bot
removed
the
needs-rebase
gabemontero
force-pushed
the
bld-csi-vol-mnt-cfg-ocm
branch
from
541dce8 to
f0b1cb0
Compare
gabemontero
changed the title
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
/assign @adambkaplan for in team approval and lgtm /assign @deads2k for approve of pulling in the openshift/api feature gate and associated openshiftcontrolplan commit you just approved for us |
Contributor
|
/approve |
openshift-ci
Bot
added
the
approved
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, deads2k, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vendoring in openshift/api#1007
ultimately, we want to leverage the feature gate observer here in library-go in openshift-controller-manager-operator with openshift/cluster-openshift-controller-manager-operator#227 to populate the new feature gate field in the openshiftcontrolplane object that @deads2k approved for us last week.