Skip to content

Bug 1734615: resourceapply: don't log secret data#494

Closed
sttts wants to merge 1 commit intoopenshift:release-4.1from
sttts:sttts-no-secret-logging-4.1
Closed

Bug 1734615: resourceapply: don't log secret data#494
sttts wants to merge 1 commit intoopenshift:release-4.1from
sttts:sttts-no-secret-logging-4.1

Conversation

@sttts
Copy link
Copy Markdown
Contributor

@sttts sttts commented Jul 31, 2019

Backport of #472

@openshift-ci-robot
Copy link
Copy Markdown

@sttts: An error was encountered searching the Bugzilla server at https://bugzilla.redhat.com for bug 1734615:

could not unmarshal response body: json: cannot unmarshal string into Go struct field Bug.alias of type int
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 1734615: resourceapply: don't log secret data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 31, 2019
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2019
@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Jul 31, 2019

/assign @enj

@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Jul 31, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Copy Markdown

@sttts: An error was encountered searching the Bugzilla server at https://bugzilla.redhat.com for bug 1734615:

could not unmarshal response body: json: cannot unmarshal string into Go struct field Bug.alias of type int
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Jul 31, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Copy Markdown

@sttts: An error was encountered searching the Bugzilla server at https://bugzilla.redhat.com for bug 1734615:

could not unmarshal response body: json: cannot unmarshal string into Go struct field Bug.alias of type int
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enj
Copy link
Copy Markdown
Contributor

enj commented Jul 31, 2019

/close

In favor of #495

@openshift-ci-robot
Copy link
Copy Markdown

@enj: Closed this PR.

Details

In response to this:

/close

In favor of #495

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Jul 31, 2019

/bugzilla refresh

@sttts sttts reopened this Jul 31, 2019
@openshift-ci-robot
Copy link
Copy Markdown

@sttts: This pull request references an invalid Bugzilla bug:

  • expected the bug to target the "4.1.z" release, but it targets "---" instead
  • expected dependent Bugzilla bug to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
  • expected dependent Bugzilla bug to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1734615: resourceapply: don't log secret data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 31, 2019
@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Jul 31, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Copy Markdown

@sttts: This pull request references an invalid Bugzilla bug:

  • expected the bug to target the "4.1.z" release, but it targets "---" instead
  • expected dependent Bugzilla bug to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
  • expected dependent Bugzilla bug to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts sttts closed this Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants