Skip to content

Create reusable package to verify images for use by CVO and oc #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jottofar wants to merge 1 commit into from
Closed

Create reusable package to verify images for use by CVO and oc #725

jottofar wants to merge 1 commit into from

Conversation

@jottofar
Copy link
Contributor

@jottofar jottofar commented Mar 3, 2020

Create reusable package for use by CVO and 'oc adm release mirror'

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 3, 2020
@jottofar
Copy link
Contributor Author

jottofar commented Mar 3, 2020

/assign @deads2k

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 3, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jottofar
To complete the pull request process, please assign deads2k
You can assign the PR to them by writing /assign @deads2k in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jottofar
Copy link
Contributor Author

jottofar commented Mar 3, 2020

/retest

@jottofar
Copy link
Contributor Author

jottofar commented Mar 3, 2020

/test verify-deps

3 similar comments
@jottofar
Copy link
Contributor Author

jottofar commented Mar 3, 2020

/test verify-deps

@jottofar
Copy link
Contributor Author

jottofar commented Mar 4, 2020

/test verify-deps

@jottofar
Copy link
Contributor Author

jottofar commented Mar 4, 2020

/test verify-deps

@jottofar
Copy link
Contributor Author

jottofar commented Mar 6, 2020

/test verify-deps

@jottofar jottofar mentioned this pull request Mar 6, 2020
Merged
jottofar added a commit to jottofar/oc that referenced this pull request Apr 2, 2020
@jottofar
WIP: implement enhancements/oc/mirroring-manifests
37f8819 
This PR implements the current baseline of openshift/enhancements#238 (which is a continuation of the work originated here: openshift/enhancements#188)

Local package pkg/verify was reused with minor changes from CVO so there is PR openshift/library-go#725 to move package verify into library-go.
jottofar added a commit to jottofar/oc that referenced this pull request Apr 2, 2020
@jottofar
WIP: implement enhancements/oc/mirroring-manifests
b63e688 
This PR implements the current baseline of openshift/enhancements#238 (which is a continuation of the work originated here: openshift/enhancements#188)

Local package pkg/verify was reused with minor changes from CVO so there is PR openshift/library-go#725 to move package verify into library-go.
jottofar added a commit to jottofar/oc that referenced this pull request Apr 2, 2020
@jottofar
WIP: implement enhancements/oc/mirroring-manifests
5fe2d40 
This PR implements the current baseline of openshift/enhancements#238 (which is a continuation of the work originated here: openshift/enhancements#188)

Local package pkg/verify was reused with minor changes from CVO so there is PR openshift/library-go#725 to move package verify into library-go.
jottofar added a commit to jottofar/oc that referenced this pull request Apr 3, 2020
@jottofar
WIP: implement enhancements/oc/mirroring-manifests
49a3d1e 
This PR implements the current baseline of openshift/enhancements#238 (which is a continuation of the work originated here: openshift/enhancements#188)

Local package pkg/verify was reused with minor changes from CVO so there is PR openshift/library-go#725 to move package verify into library-go.
jottofar added a commit to jottofar/oc that referenced this pull request Apr 3, 2020
@jottofar
WIP: implement enhancements/oc/mirroring-manifests
c09ed1c 
This PR implements the current baseline of openshift/enhancements#238 (which is a continuation of the work originated here: openshift/enhancements#188)

Local package pkg/verify was reused with minor changes from CVO so there is PR openshift/library-go#725 to move package verify into library-go.
jottofar added a commit to jottofar/oc that referenced this pull request Apr 7, 2020
@jottofar
WIP: implement enhancements/oc/mirroring-manifests
e915b74 
This PR implements the current baseline of openshift/enhancements#238 (which is a continuation of the work originated here: openshift/enhancements#188)

Local package pkg/verify was reused with minor changes from CVO so there is PR openshift/library-go#725 to move package verify into library-go.
jottofar added a commit to jottofar/oc that referenced this pull request Apr 9, 2020
@jottofar
Implement enhancements/oc/mirroring-release-signatures
c46131d 
This PR implements the openshift/enhancements#283

Local package pkg/verify was reused with minor changes from CVO so there is PR openshift/library-go#725 to move package verify into library-go.
@openshift-bot
Copy link

openshift-bot commented Oct 2, 2020

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 2, 2020
@openshift-bot
Copy link

openshift-bot commented Nov 1, 2020

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 1, 2020
@jottofar
Copy link
Contributor Author

jottofar commented Nov 2, 2020

/close

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 2, 2020

@jottofar: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@deads2k deads2k

Labels

lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jottofar @openshift-ci-robot @openshift-bot @deads2k