Bug 1915467: cherry-pick hooks helpers and config observer#986
Bug 1915467: cherry-pick hooks helpers and config observer#986openshift-merge-robot merged 5 commits intoopenshift:release-4.6from
Conversation
Some CSI Drivers need to be given a cluster ID so that they can tag volumes and snapshots they create. This is done so that the installer can filter those resources out and delete them on cluster deletion.
Cloud CSI drivers perform all sorts of operations using the cloud API. However, that's not possible in network-restricted clusters, where requests need to go through a given proxy, unless they target the API server. This patch adds a CSI Config Observer controller to observe the proxy resource and record the information in the operator CR. It also adds a hook function to inject the observed proxy config into the deployment's containers.
openshift-ci-robot
added
bugzilla/severity-urgent
|
@bertinatto: This pull request references Bugzilla bug 1915467, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
bertinatto
changed the title
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/assign @deads2k |
|
/lgtm |
|
This change is contained to the storage bits of this library. I leave it up to the storage team to handle any communication that needs to happen to dependent components. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, deads2k, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@bertinatto: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1915467 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
Originally this was a backport of #976.
However, that PR relied on functionality added by PRs #968 and #909, so those had to be backported as well.
CC @openshift/storage