OCPCLOUD-2565: Bump openshift/api#1256
OCPCLOUD-2565: Bump openshift/api#1256openshift-merge-bot[bot] merged 7 commits intoopenshift:masterfrom
Conversation
a4279b0 to
b69e0db
Compare
|
/retest-required |
36eca23 to
3798654
Compare
|
Looks like the CRD sync needs re-running, and perhaps, clear the dir before you run it just to make sure everything is clean there? |
|
@JoelSpeed something weird is going on with my local machine or with git, where the rename is not noticing the case change. machine-api-operator on bump-api via 🐳 desktop-linux via 🐹 v1.22.4 on ☁️ tbarberb@redhat.com(us-east1)
❯ ls -la install | grep Default
-rw-r--r-- 1 tbarberb staff 28058 Jun 6 12:33 0000_30_machine-api-operator_02_machine.Default.crd.yaml
-rw-r--r-- 1 tbarberb staff 36682 Jun 6 12:33 0000_30_machine-api-operator_03_machineset.Default.crd.yaml
machine-api-operator on bump-api via 🐳 desktop-linux via 🐹 v1.22.4 on ☁️ tbarberb@redhat.com(us-east1)
❯ ls -la install | grep defaultbut in the git diff: |
|
Try using |
|
This was initially done with a edit: seems to have worked :D |
|
/lgtm |
|
@theobarberbany: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@theobarberbany: This pull request references OCPCLOUD-2565 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-machine-api-operator-container-v4.17.0-202406061914.p0.g148e5dc.assembly.stream.el9 for distgit ose-machine-api-operator. |
Notice that we had to also bump machine-api-operator to include [1] so it would build with the latest openshift/api. [1] openshift/machine-api-operator#1256
No description provided.