Skip to content

OCPCLOUD-2738: Update dependencies to K8s 1.31#1292

Merged
openshift-merge-bot[bot] merged 4 commits intoopenshift:masterfrom
JoelSpeed:bump-1.31
Sep 24, 2024
Merged

OCPCLOUD-2738: Update dependencies to K8s 1.31#1292
openshift-merge-bot[bot] merged 4 commits intoopenshift:masterfrom
JoelSpeed:bump-1.31

Conversation

@JoelSpeed
Copy link
Copy Markdown
Contributor

This PR updates the MAO dependencies to be inline with K8s 1.31 ahead of the 4.18 rebase.

Controller runtime has more breaking changes handled here:

  • You must now have more generics in more places - 3rd commit handles these
  • Controller names must now be unique - useful for production, less useful for testing, added a skip name validation in the test where this was affected

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 23, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 23, 2024

@JoelSpeed: This pull request references OCPCLOUD-2738 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

Details

In response to this:

This PR updates the MAO dependencies to be inline with K8s 1.31 ahead of the 4.18 rebase.

Controller runtime has more breaking changes handled here:

  • You must now have more generics in more places - 3rd commit handles these
  • Controller names must now be unique - useful for production, less useful for testing, added a skip name validation in the test where this was affected

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from racheljpg and sub-mod September 23, 2024 13:16
Copy link
Copy Markdown
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Until happy
/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2024
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2024
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
@JoelSpeed
Copy link
Copy Markdown
Contributor Author

/hold cancel
/retest-required

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2024
@theobarberbany
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 24, 2024

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack a57aee3 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-ovn-ipv6 a57aee3 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-vsphere-ovn-serial a57aee3 link false /test e2e-vsphere-ovn-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 1efafa4 into openshift:master Sep 24, 2024
@openshift-bot
Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-api-operator
This PR has been included in build ose-machine-api-operator-container-v4.18.0-202409241443.p0.g1efafa4.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants