Skip to content

Conversation

@russellb
Copy link
Contributor

There were various links that have gone stale in the README due to
renames in the repo.

There were various links that have gone stale in the README due to
renames in the repo.
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 21, 2019
@paulfantom
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulfantom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2019
@openshift-ci-robot
Copy link
Contributor

@russellb: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 0c34828 link /test e2e-aws
ci/prow/e2e-aws-operator 0c34828 link /test e2e-aws-operator

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

- Create a [CRD Cluster definition](test/integration/manifests/0000_30_machine-api-operator_05_cluster.crd.yaml)
- Create a [Installer config](test/integration/manifests/install-config.yaml)
- Then you can run it as a [deployment](install/0000_50_machine-api-operator_08_deployment.yaml)
- Then you can run it as a [deployment](install/0000_30_machine-api-operator_14_deployment.yaml)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/14/9

@openshift-ci-robot
Copy link
Contributor

@russellb: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2019
@russellb
Copy link
Contributor Author

russellb commented Mar 8, 2019

looks like this got fixed by #242

@russellb russellb closed this Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants