Skip to content

Fix links to operator status and install config #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 4, 2019
Merged

Fix links to operator status and install config #251

openshift-merge-robot merged 1 commit into from
Apr 4, 2019

Conversation

@ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Mar 20, 2019

install-config.yaml and config/status-crd.yaml were removed by #240. Adding the files back and updating links to them.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 20, 2019
@ingvagabund ingvagabund force-pushed the update-readme-links branch from 552d774 to abcbb45 Compare March 20, 2019 11:50
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 20, 2019
@ingvagabund ingvagabund force-pushed the update-readme-links branch from abcbb45 to ef1887f Compare March 20, 2019 11:51
frobware
frobware reviewed Mar 20, 2019
View reviewed changes
config/machineset.yaml
credentialsSecret:
name: aws-credentials-secret
ami:
id: ami-05c79276d240b93bc
Copy link
Contributor

@frobware frobware Mar 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this? Will it always be around?

Copy link
Member Author

@ingvagabund ingvagabund Mar 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most likely not

Copy link
Member Author

@ingvagabund ingvagabund Mar 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a user will have to substitute those values

config/status-crd.yaml Outdated
subresources:
status: {}
version: v1

Copy link
Contributor

@frobware frobware Mar 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: drop blank/empty lines at end of file.

Copy link
Member Author

@ingvagabund ingvagabund Mar 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy-paste heresy. harmless

@ingvagabund
Copy link
Member Author

ingvagabund commented Mar 20, 2019

@frobware I only copy pasted the files, did not intend the modify their content. If the content needs to be changed, we might put it into a separate PR.

enxebre
enxebre reviewed Mar 22, 2019
View reviewed changes
@ingvagabund ingvagabund force-pushed the update-readme-links branch from ef1887f to 5396196 Compare March 26, 2019 13:50
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 26, 2019
@ingvagabund
Copy link
Member Author

ingvagabund commented Mar 26, 2019

@enxebre comments addressed, PTAL

@ingvagabund
Copy link
Member Author

ingvagabund commented Apr 4, 2019

/retest

@ingvagabund ingvagabund force-pushed the update-readme-links branch from 5396196 to d03af9b Compare April 4, 2019 08:16
@enxebre
Copy link
Member

enxebre commented Apr 4, 2019

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2019
michaelgugino
michaelgugino approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a17abf3 into openshift:master Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frobware frobware frobware left review comments

@enxebre enxebre enxebre left review comments

@paulfantom paulfantom Awaiting requested review from paulfantom

+1 more reviewer

@michaelgugino michaelgugino michaelgugino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@michaelgugino michaelgugino

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ingvagabund @enxebre @openshift-ci-robot @openshift-bot @frobware @michaelgugino @openshift-merge-robot