Skip to content

Add machine and labels explanation#306

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
enxebre:docs
May 3, 2019
Merged

Add machine and labels explanation#306
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
enxebre:docs

Conversation

@enxebre
Copy link
Copy Markdown
Member

@enxebre enxebre commented Apr 29, 2019

Add machine and labels explanation

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 29, 2019
@enxebre enxebre mentioned this pull request Apr 29, 2019
Merged
michaelgugino
michaelgugino reviewed Apr 29, 2019
View reviewed changes
Comment thread README.md Outdated

You can create a new machine by applying a manifest representing an instance of the machine CRD:
```
apiVersion: machine.openshift.io/v1beta1
Copy link
Copy Markdown
Contributor

@michaelgugino michaelgugino Apr 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to authoritative source instead of inline? This information is possible to go stale.

@wking wking mentioned this pull request Apr 30, 2019
Merged
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 30, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 30, 2019
DanyC97
DanyC97 reviewed May 1, 2019
View reviewed changes
Comment thread README.md
You can set other labels to provide a convenient way for users and consumers to retrieve groups of machines:
```
machine.openshift.io/cluster-api-machine-role: worker
machine.openshift.io/cluster-api-machine-type: worker
Copy link
Copy Markdown

@DanyC97 DanyC97 May 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq @enxebre : could users set custom labels like foo: bar or it always needs to follow the above convention machine.openshift.io/cluster-api-machine-role such that consumers can know how to filter?

Copy link
Copy Markdown
Member Author

@enxebre enxebre May 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanyC97 these are arbitrary labels in the sense that the core controller does not use them today. You might still want to use the machine.openshift.io/ namespace for consistency and searchability. However you could change them or/and add new labels at your convenience

Copy link
Copy Markdown

@DanyC97 DanyC97 May 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @enxebre for taking the time to respond 👍

@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented May 2, 2019 

level=error
level=error msg="1 error occurred:"
level=error msg="\t* module.bootstrap.aws_security_group.bootstrap (destroy): 1 error occurred:"
level=error msg="\t* aws_security_group.bootstrap: timeout while waiting for state to become 'success' (timeout: 10m0s)"

/retest

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 2, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 2, 2019
@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented May 2, 2019 

level=error msg="\t* module.vpc.aws_internet_gateway.igw: 1 error occurred:"
level=error msg="\t* aws_internet_gateway.igw: error attaching EC2 Internet Gateway (igw-0f20eeb305927e7f0): timeout while waiting for state to become 'success' (timeout: 2m0s)"
level=error

/retest

@frobware
Copy link
Copy Markdown
Contributor

frobware commented May 2, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2019
@ingvagabund
Copy link
Copy Markdown
Member

ingvagabund commented May 2, 2019

/approve

@ingvagabund
Copy link
Copy Markdown
Member

ingvagabund commented May 2, 2019

/retest

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2019
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 3, 2019 •
edited
Loading

@enxebre: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/actuator-pkg-staleness fcaf68a link /test actuator-pkg-staleness

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 1dfc752 into openshift:master May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikaschoudhary16 vikaschoudhary16 Awaiting requested review from vikaschoudhary16

2 more reviewers

@michaelgugino michaelgugino michaelgugino left review comments

@DanyC97 DanyC97 DanyC97 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@frobware frobware

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@enxebre @frobware @ingvagabund @openshift-ci-robot @openshift-bot @michaelgugino @DanyC97 @openshift-merge-robot