Update configuration to work with new actuator #32
Conversation
openshift-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bison If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test e2e |
|
/retest |
| @@ -1,6 +1,12 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
We should move this into the examples folder
| memory: 30Mi | ||
| - name: aws-machine-controller | ||
| image: quay.io/alberto_lamela/aws-machine-controller:mvp # TODO: move this to openshift org | ||
| image: quay.io/bison/aws-machine-controller:cfc14e5 # TODO: move this to openshift org |
There was a problem hiding this comment.
We should be able to use image built by CI now? cc @ingvagabund
There was a problem hiding this comment.
I see machine-api-operator images in the output of oc describe is -n openshift origin-v3.11 --server https://api.ci.openshift.org but they reference the internal registry on that cluster. The images are supposed to be mirrored to Quay and Docker Hub, but I'm not sure where to find them.
machines/machine-set.yaml
Outdated
| ami: | ||
| id: "{{ .MachineConfig.AMI }}" | ||
| credentialsSecret: | ||
| name: aws-credentials-secret |
There was a problem hiding this comment.
This is not available on the installer, we should omit it so the aws client uses the machine ami role
There was a problem hiding this comment.
Makes sense. This is nice for testing locally with the AWS actuator though. It should probably just be optional.
There was a problem hiding this comment.
Pushed a quick fix to make this optional.
|
See follow up for consolidating config here https://jira.coreos.com/browse/CLOUD-138 |
|
I didn't get a chance to test via the installer yet. I'll give that a shot. |
This updates the configuration to allow working with an up-to-date AWS actuator image. This is only a starting point. It does not cover the complete set of options available in the provider config types.
|
closed via #35 |
…ptables Set bridge-nf-call-iptables
Switch to go modules
…phase OCPBUGS-4574: Machines with invalid zones stuck in no phase
4 participants
This is just a quick fix so we can start testing with a newer actuator image. We need to spend more time thinking about the types here and exposing more of the available options.