Skip to content

Add OpenStack credentials request#324

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
mandre:openstack-creds
Jun 13, 2019
Merged

Add OpenStack credentials request#324
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
mandre:openstack-creds

Conversation

@mandre
Copy link
Copy Markdown
Member

@mandre mandre commented Jun 13, 2019

This will be used by the installer to get the creds in the
openshift-machine-api namespace.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 13, 2019
mandre added a commit to mandre/installer that referenced this pull request Jun 13, 2019
@mandre
openstack: Retrieve namespaced credentials
e17a5a1 
With openshift/machine-api-operator#315 the Machine API Operator
doesn't have access to the `kube-system` namespace anymore.

We now need to issue a CredentialsRequest in MAO and retrieve it from
the `openshift-machine-api` namespace here.

Needs openshift/machine-api-operator#324
@mandre mandre mentioned this pull request Jun 13, 2019
Merged
@mandre
Add OpenStack credentials request
724b04a 
This will be used by the installer to get the creds in the
openshift-machine-api namespace.
@mandre mandre force-pushed the openstack-creds branch from ef4307e to 724b04a Compare June 13, 2019 16:19
@mandre
Copy link
Copy Markdown
Member Author

mandre commented Jun 13, 2019

/cc @ingvagabund @enxebre

@trown
Copy link
Copy Markdown

trown commented Jun 13, 2019

/retest

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jun 13, 2019 •
edited
Loading

@mandre: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/actuator-pkg-staleness 724b04a link /test actuator-pkg-staleness

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ingvagabund
Copy link
Copy Markdown
Member

ingvagabund commented Jun 13, 2019

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jun 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2019
@openshift-merge-robot openshift-merge-robot merged commit eb4d421 into openshift:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@spangenberg spangenberg Awaiting requested review from spangenberg

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@ingvagabund ingvagabund

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mandre @trown @openshift-ci-robot @ingvagabund @openshift-merge-robot