Skip to content

Add node to machine additionalPrinterColumns#365

Closed
enxebre wants to merge 1 commit intoopenshift:masterfrom
enxebre:print-node
Closed

Add node to machine additionalPrinterColumns#365
enxebre wants to merge 1 commit intoopenshift:masterfrom
enxebre:print-node

Conversation

@enxebre
Copy link
Copy Markdown
Member

@enxebre enxebre commented Jul 29, 2019

Add node to machine additionalPrinterColumns

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign enxebre
You can assign the PR to them by writing /assign @enxebre in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 29, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@enxebre: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-operator 4128f1b link /test e2e-aws-operator

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

description: Zone associated with machine
name: Zone
type: string
- JSONPath: .status.nodeRef.name
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be set in machine_types.go first and the CRD updated by running make gen-crd. Otherwise, your change will get removed after the CRD gets regen again. Let's collect all the bits in openshift/cluster-api#55 first.

@ingvagabund
Copy link
Copy Markdown
Member

Part of #360

@ingvagabund ingvagabund closed this Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants