Skip to content

Conversation

@bison
Copy link
Contributor

@bison bison commented Sep 17, 2018

We've been using the wrong IAM profile here.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 17, 2018
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 17, 2018
@bison bison changed the title Make AWS worker IAM instance profile configurable Use correct IAM profile for worker machines Sep 17, 2018
@enxebre
Copy link
Member

enxebre commented Sep 17, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2018
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2018
@enxebre
Copy link
Member

enxebre commented Sep 17, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bison, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b6a04c2 into openshift:master Sep 17, 2018
@bison bison deleted the aws-iam-profile branch September 17, 2018 18:41
ingvagabund pushed a commit to ingvagabund/machine-api-operator that referenced this pull request Jul 11, 2019
…ions

Add machine creation/failure conditions to AWS machine provider status.
germanparente pushed a commit to germanparente/machine-api-operator that referenced this pull request Sep 23, 2025
Label instances created by the actuator with cluster ID
germanparente pushed a commit to germanparente/machine-api-operator that referenced this pull request Sep 23, 2025
OCPBUGS-18338: Fix CI by running tests natively by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants