Skip to content

Conversation

@n1r1
Copy link
Contributor

@n1r1 n1r1 commented Apr 9, 2021

this is the same as #795 but hopefully with no conflicts.
I have no access to push commits to that PR so trying my luck as new PR since FF is coming.

mshitrit added 3 commits April 9, 2021 19:54
Signed-off-by: Michael Shitrit <mshitrit@redhat.com>
…s etc..

Signed-off-by: Michael Shitrit <mshitrit@redhat.com>
Signed-off-by: Michael Shitrit <mshitrit@redhat.com>
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine to me, but i guess we will need to figure out if this or #795 should be the PR to take forward. also, seems like we will need to make a decision about how, or if, to bring this in given the release cycle.
/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 9, 2021

@n1r1: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade 0a92707 link /test e2e-aws-upgrade
ci/prow/e2e-gcp 0a92707 link /test e2e-gcp
ci/prow/e2e-azure 0a92707 link /test e2e-azure
ci/prow/e2e-vsphere 0a92707 link /test e2e-vsphere
ci/prow/e2e-aws-operator 0a92707 link /test e2e-aws-operator
ci/prow/e2e-libvirt 0a92707 link /test e2e-libvirt
ci/prow/e2e-azure-operator 0a92707 link /test e2e-azure-operator
ci/prow/e2e-vsphere-upgrade 0a92707 link /test e2e-vsphere-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elmiko
Copy link
Contributor

elmiko commented Apr 9, 2021

i talked with @mshitrit and #795 is all fixed up. i am going to close this so we can keep the history on the other pr.
/close

@openshift-ci-robot
Copy link
Contributor

@elmiko: Closed this PR.

Details

In response to this:

i talked with @mshitrit and #795 is all fixed up. i am going to close this so we can keep the history on the other pr.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants