Skip to content

NO-JIRA: bump k8s 1.34: bump Makefile and Dockerfile#158

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
damdo:bump-k8s-1.34-followups
Nov 20, 2025
Merged

NO-JIRA: bump k8s 1.34: bump Makefile and Dockerfile#158
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
damdo:bump-k8s-1.34-followups

Conversation

@damdo
Copy link
Copy Markdown
Member

@damdo damdo commented Nov 18, 2025

A follow up to #156

To address the things mentioned here: #156 (comment)

@damdo damdo requested review from RadekManak and mdbooth November 18, 2025 09:16
@damdo
Copy link
Copy Markdown
Member Author

damdo commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 18, 2025

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@damdo damdo changed the title bump k8s 1.34: bump Makefile and Dockerfile NO-JIRA: bump k8s 1.34: bump Makefile and Dockerfile Nov 18, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 18, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@damdo: This pull request explicitly references no jira issue.

Details

In response to this:

A follow up to #156

To address the things mentioned here: #156 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@damdo
Copy link
Copy Markdown
Member Author

damdo commented Nov 18, 2025

/verified by units and images jobs passed

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 18, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@damdo: This PR has been marked as verified by units and images jobs passed.

Details

In response to this:

/verified by units and images jobs passed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@damdo damdo added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit ff23a96 into openshift:main Nov 20, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants