templates: change etcd-member to notify type#104
Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom Oct 2, 2018
crawford:etcd
Merged
templates: change etcd-member to notify type#104openshift-merge-robot merged 2 commits intoopenshift:masterfrom crawford:etcd
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
crawford:etcd
Conversation
This just cleans up the indentation to match the other stanzas.
openshift-ci-robot
added
approved
Contributor
|
@crawford can you run |
Now that podman is being used, we can actually use systemd's notify
mechanism. This allows systemd to more accurately track etcd's state and
it removes the following warning:
etcdmain: forgot to set Type=notify in systemd service file?
openshift-ci-robot
added
size/L
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, crawford The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
osherdp
pushed a commit
to osherdp/machine-config-operator
that referenced
this pull request
Apr 13, 2021
need some more verification of operator processing of config change i…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that podman is being used, we can actually use systemd's notify
mechanism. This allows systemd to more accurately track etcd's state and
it removes the following warning: