[4.3] pkg/daemon: MCD constants fixup#1058
[4.3] pkg/daemon: MCD constants fixup#1058openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/XS
|
since it's so small i think you can squash commits 1 & 3 |
kikisdeliveryservice
changed the title
|
just adding a hold for now since this isn't a bugfix. thanks for this! /hold |
openshift-ci-robot
added
the
do-not-merge/hold
sgreene570
force-pushed
the
mcd-constants-fixup
branch
from
4aff356 to
555110d
Compare
sgreene570
force-pushed
the
mcd-constants-fixup
branch
from
555110d to
d99a7dc
Compare
runcom
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: runcom, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
12 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
these retests are flooding my inbox. |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 participants
- What I did
Add the
"openshift.io/operator-managed"label from #832 to the MCD global constants file.This way the operator managed label can be easily swapped out if the need arises (once #817 is merged the label will be used more than once, and it is an important label).
I also cleaned up some small typos in the constants file.
- How to verify it
CI