[fcos] retry pulling mcd image#1273
Conversation
It doesn't have to be oneshot, as there is no kubelet on FCOS
openshift-ci-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
@vrutkovs: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| [Service] | ||
| # Need oneshot to delay kubelet | ||
| Type=oneshot | ||
| Type=simple |
There was a problem hiding this comment.
(there is no kubelet on base FCOS and it hasn't pivoted yet)
I don't quite get how this is related? We need to block kubelet on RHCOS for sure.
There was a problem hiding this comment.
fcos branch, this is not going to master yet
There was a problem hiding this comment.
Right, I would just be curious to understand why you made this change. It's not necessary for Restart= is it?
| ExecStart=/usr/bin/chmod +x /usr/local/bin/machine-config-daemon | ||
| ExecStart=/usr/sbin/restorecon /usr/local/bin/machine-config-daemon | ||
| Restart=on-failure | ||
| RestartSec=30 |
There was a problem hiding this comment.
Seems reasonable, though at some point we will need to bubble up provisioning failures.
|
Superseded by #1279 |
3 participants
- What I did
machine-config-daemon-pull.servicetosimple(there is no kubelet on base FCOS and it hasn't pivoted yet)- How to verify it
This would cut amount of flakes due to registry pulls
- Description for the changelog
Retry pulling MCD image on FCOS systems
TODO:
/cc @LorbusChris