Skip to content

[fcos] *: conditionally populate the images configmap with cluster-etcd-operator image #1413

Closed
openshift-cherrypick-robot wants to merge 4 commits intoopenshift:fcosfrom
openshift-cherrypick-robot:cherry-pick-1288-to-fcos
Closed

[fcos] *: conditionally populate the images configmap with cluster-etcd-operator image #1413
openshift-cherrypick-robot wants to merge 4 commits intoopenshift:fcosfrom
openshift-cherrypick-robot:cherry-pick-1288-to-fcos

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #1288

/assign vrutkovs

EtcdInformer is only used by the MCO pod to reconcile image names.
This pulls out the logic of creating etcd informer from the generic
controller context to MCO pod start method.
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign ashcrow
You can assign the PR to them by writing /assign @ashcrow in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws 7ce0aa0 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kikisdeliveryservice kikisdeliveryservice requested review from LorbusChris and removed request for ericavonb and kikisdeliveryservice January 28, 2020 20:44
@vrutkovs
Copy link
Copy Markdown
Contributor

Superseded by 1415

/close

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@vrutkovs: Closed this PR.

Details

In response to this:

Superseded by 1415

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants