Skip to content

Bug 1797647: [release-4.3] [baremetal] Ipv6 non virtual ip fix#1445

Closed
openshift-cherrypick-robot wants to merge 2 commits intoopenshift:release-4.3from
openshift-cherrypick-robot:cherry-pick-1436-to-release-4.3
Closed

Bug 1797647: [release-4.3] [baremetal] Ipv6 non virtual ip fix#1445
openshift-cherrypick-robot wants to merge 2 commits intoopenshift:release-4.3from
openshift-cherrypick-robot:cherry-pick-1436-to-release-4.3

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Feb 6, 2020

This is an automated cherry-pick of #1436

/assign hardys

@celebdor
baremetal IPv6: Use route adv to find non-vip
e6b17f7 
In IPv6 DHCPv6 environments, the prefix for the IPv6 address that we
must use to bind services may be 128. In case that happens, the current
detection code will fail to consider the address as being in the right
subnet.

Thankfully, thanks to the Route Advertisements, we get the prefix
information we need from the routing table. This patch adds the extra
code to generate pseudo CIDRs that allow us to check if an address is in
the right subnet.

Signed-off-by: Antoni Segura Puimedon <antoni@redhat.com>
@celebdor
baremetal IPv6: filtering improvement
06ae96d 
This patch simplifies filtering by:
* Calling iface_cidrs only once,
* Filtering out IPv6 addresses marked with the *deprecated* flag
* Allowing multiple filters

Signed-off-by: Antoni Segura Puimedon <antoni@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 6, 2020
Merged
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 6, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 6, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1798146, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "4.4.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead
  • expected Bugzilla bug 1798146 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1798146: [baremetal] Ipv6 non virtual ip fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 6, 2020
@hardys
Copy link
Copy Markdown

hardys commented Feb 6, 2020

/retitle Bug 1797647: [release-4.3] [baremetal] Ipv6 non virtual ip fix

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] Bug 1798146: [baremetal] Ipv6 non virtual ip fix Bug 1797647: [release-4.3] [baremetal] Ipv6 non virtual ip fix Feb 6, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 6, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1797647, which is invalid:

  • expected dependent Bugzilla bug 1798146 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1797647: [release-4.3] [baremetal] Ipv6 non virtual ip fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship
Copy link
Copy Markdown
Contributor

danwinship commented Feb 11, 2020

/bugzilla refresh
/retest

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 11, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 11, 2020

@danwinship: This pull request references Bugzilla bug 1797647, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@russellb
Copy link
Copy Markdown
Contributor

russellb commented Feb 12, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2020
@sinnykumari
Copy link
Copy Markdown
Contributor

sinnykumari commented Feb 12, 2020

/retest

@kikisdeliveryservice kikisdeliveryservice requested review from kikisdeliveryservice and removed request for LorbusChris February 12, 2020 18:45
@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

kikisdeliveryservice commented Feb 12, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 12, 2020

@kikisdeliveryservice: This pull request references Bugzilla bug 1797647, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 12, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, openshift-cherrypick-robot, russellb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2020
@russellb russellb mentioned this pull request Feb 12, 2020
Merged
@russellb
Copy link
Copy Markdown
Contributor

russellb commented Feb 12, 2020

Replaced by #1466

@russellb
Copy link
Copy Markdown
Contributor

russellb commented Feb 12, 2020

/close

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 12, 2020

@russellb: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@runcom runcom Awaiting requested review from runcom

1 more reviewer

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@russellb russellb

@hardys hardys

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@openshift-cherrypick-robot @openshift-ci-robot @hardys @danwinship @russellb @sinnykumari @kikisdeliveryservice @celebdor