templates: switch kubelet systemd unit to type notify#146
templates: switch kubelet systemd unit to type notify#146openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
kubelet supports running as systemd unit and sends READY=1 signal when running. https://github.com/kubernetes/kubernetes/blob/12cf5451952c8425a47334465f3e03d7ca181956/cmd/kubelet/app/server.go#L761-L762
openshift-ci-robot
added
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold We tried this before and hit an issue in crio. Has that issue been fixed? |
openshift-ci-robot
added
the
do-not-merge/hold
|
@rphillips Kubelet doesn't run in crio. |
|
Maybe the issue was with the systemd we are using. I'm searching for the issue. |
|
@rphillips Are you thinking of opencontainers/runc#1807? |
|
/retest |
|
@crawford Ah yes... Has that been resolved? Does it apply to this issue? |
|
/hold cancel Sorry for the noise... Thanks for finding the issue for me. |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@rphillips No, it doesn't apply here. That issue affects instances where we use Podman in a notify service unit. |
…rmer-cachestore Bug 1707834: use informer cache instead of api server for GETs on tem…
6 participants
kubelet supports running as systemd unit and sends READY=1 signal when running.
https://github.com/kubernetes/kubernetes/blob/12cf5451952c8425a47334465f3e03d7ca181956/cmd/kubelet/app/server.go#L761-L762
/cc @crawford @sjenning @rphillips