Skip to content

Update vendor for github.com/cri-o/cri-o#1599

Closed
umohnani8 wants to merge 1 commit intoopenshift:masterfrom
umohnani8:crio-update
Closed

Update vendor for github.com/cri-o/cri-o#1599
umohnani8 wants to merge 1 commit intoopenshift:masterfrom
umohnani8:crio-update

Conversation

@umohnani8
Copy link
Copy Markdown
Contributor

- What I did
Update vendor for github.com/cri-o/cri-o to pull in latest changes

- How to verify it

- Description for the changelog
Update the version of cri-o that is vendored in
to be able to pick up new functionality.

Signed-off-by: Urvashi Mohnani umohnani@redhat.com

Update the version of cri-o that is vendored in
to be able to pick up new functionality.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
@umohnani8
Copy link
Copy Markdown
Contributor Author

cc @haircommander

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: umohnani8
To complete the pull request process, please assign yuqi-zhang
You can assign the PR to them by writing /assign @yuqi-zhang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haircommander
Copy link
Copy Markdown
Member

can you also regenerate the template? I know it'll be dropped soon with the drop-in change, but in the meantime we should have config files matching the cri-o version

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@umohnani8: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify 8db3ea7 link /test verify
ci/prow/e2e-gcp-op 8db3ea7 link /test e2e-gcp-op

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Copy Markdown
Member

/hold

let's get #1600 in first

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@umohnani8: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2020
@runcom
Copy link
Copy Markdown
Member

runcom commented Apr 11, 2020

/hold

let's get #1600 in first

#1600 got in, should you proceed with rebasing this and getting this for 4.5?

@haircommander
Copy link
Copy Markdown
Member

/hold cancel

yes, let's get this in now 😃

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2020
@umohnani8
Copy link
Copy Markdown
Contributor Author

Closing in favour of #1660

@umohnani8 umohnani8 closed this Apr 16, 2020
@umohnani8 umohnani8 deleted the crio-update branch January 22, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants