Skip to content

[Baremetal, Openstack,Vsphere, Ovirt] Update fall and rise values in keepalived check scripts#1721

Closed
yboaron wants to merge 1 commit intoopenshift:masterfrom
yboaron:keepalived_fall_rise
Closed

[Baremetal, Openstack,Vsphere, Ovirt] Update fall and rise values in keepalived check scripts#1721
yboaron wants to merge 1 commit intoopenshift:masterfrom
yboaron:keepalived_fall_rise

Conversation

@yboaron
Copy link
Copy Markdown
Contributor

@yboaron yboaron commented May 10, 2020

Keepalived runs a check script every interval (1 Sec in our case) to calculate VRRP instance's status.
The check script must succeed 'rise' times for the instance to be considered as 'healthy and fail 'fall'
time to be considered as 'non healthy'.

This change updates 'rise' and 'fall' values from the default (1 for both of them) to 3 and 2.

- What I did

- How to verify it

- Description for the changelog

Keepalived runs a check script every interval (1 Sec in our case) to calculate VRRP instance's status.
The check script must succeed 'rise' times for the instance to be considered  as 'healthy and fail 'fall'
time to be considered as 'non healthy'.

This change updates 'rise' and 'fall' values from the default (1 for both of them) to 3 and 2.
@openshift-ci-robot openshift-ci-robot requested a review from hardys May 10, 2020 20:23
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yboaron
To complete the pull request process, please assign ericavonb
You can assign the PR to them by writing /assign @ericavonb in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcpowermac
Copy link
Copy Markdown
Contributor

cc: @patrickdillon @mtnbikenc

@pierreprinetti
Copy link
Copy Markdown
Contributor

/test e2e-openstack
Our CI is currently unable to give reliable results, however putting this here ready for a /retest

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@yboaron: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-op e22f911 link /test e2e-gcp-op
ci/prow/e2e-ovn-step-registry e22f911 link /test e2e-ovn-step-registry
ci/prow/e2e-openstack e22f911 link /test e2e-openstack

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yboaron yboaron closed this Jun 28, 2020
@yboaron
Copy link
Copy Markdown
Contributor Author

yboaron commented Jun 28, 2020

The Keepalived failure detection timing being handled by #1744 , so we can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants