Bug 1825967: revert: etcd quorum guard: don't set hostNetwork#1732
Bug 1825967: revert: etcd quorum guard: don't set hostNetwork#1732openshift-merge-robot merged 3 commits intoopenshift:masterfrom
Conversation
|
@hexfusion: This pull request references Bugzilla bug 1825967, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@hexfusion: This pull request references Bugzilla bug 1825967, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
LGTM |
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hexfusion, kikisdeliveryservice, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hexfusion: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1732. Bugzilla bug 1825967 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
After a conversation with @eparis about the fact that this change adds a dependency on SDN to quorum-guard health checks for etcd I feel this should be reverted. The fear would be false negatives on health. Although the cluster would have other problems if SDN were down we don't want to triage that layer if we don't have to.
cc @vrutkovs @sdodson
This PR reverts
Note this change was not made in 4.4