Bug 1854249: [On-Prem] Workaround issues with keepalived v2.0.10#1909
Conversation
openshift-ci-robot
added
the
approved
|
/test e2e-openstack |
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
/test e2e-openstack |
1 similar comment
|
/test e2e-openstack |
|
Am I right that the command is the same, but you just created a one-liner script instead of calling it directly? |
|
/test e2e-openstack |
|
/test e2e-openstack |
This commit extracts the chk_ocp script into a separate file and wraps the check scripts with the timeout command to workaround acassen/keepalived#1364.
openshift-ci-robot
removed
the
approved
mandre
changed the title
openshift-ci-robot
added
the
bugzilla/severity-urgent
|
@mandre: This pull request references Bugzilla bug 1854249, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test e2e-openstack |
|
@mandre: This pull request references Bugzilla bug 1854249, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@mandre: This pull request references Bugzilla bug 1854249, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/retest |
|
/approve |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
9 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Q: do we expect vsphere job to pass with this PR @mandre ? |
|
/lgtm This worked for me locally. I think the flapping of the VIP will be helped by #1893 which adds rise and fall values to the check so they won't immediately cause failover because of a single timeout. This should get us back to where we were though. I think @patrickdillon is the vsphere contact, so maybe he can comment on the status of the vsphere job. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: celebdor, cybertron, mandre, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@mandre: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@mandre: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1909. Bugzilla bug 1854249 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
9 participants
- What I did
This commit extracts the chk_ocp script into a separate file and wraps
the check scripts with the timeout command to workaround
acassen/keepalived#1364.
This PR supersedes #1908.
Co-Authored-By: Yossi Boaron yboaron@redhat.com
Co-Authored-By: Ben Nemec bnemec@redhat.com
- How to verify it
Installer can deploy OCP on on-prem platform again.
- Description for the changelog
Wrap keepalived checks with timeout to workaround known issue with keepalived v2.0.10.