Skip to content

Bug 1855373: etcd: remove etcd entries from mdns#1917

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.5from
openshift-cherrypick-robot:cherry-pick-1556-to-release-4.5
Aug 17, 2020
Merged

Bug 1855373: etcd: remove etcd entries from mdns#1917
openshift-merge-robot merged 1 commit intoopenshift:release-4.5from
openshift-cherrypick-robot:cherry-pick-1556-to-release-4.5

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #1556

/assign cybertron

Similar to openshift/installer#3265, this
removes the etcd entries from mdns config because etcd no longer uses
DNS.
@cybertron
Copy link
Copy Markdown
Member

This is for bug 1855224. I can't edit the title.

/cc @mandre @rgolangh @patrickdillon

@mandre
Copy link
Copy Markdown
Member

mandre commented Jul 9, 2020

/retitle Bug 1855224: [release-4.5] etcd: remove etcd entries from mdns
/test e2e-openstack
/test e2e-ovirt
/test e2e-vsphere

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] etcd: remove etcd entries from mdns Bug 1855224: [release-4.5] etcd: remove etcd entries from mdns Jul 9, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jul 9, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1855224, which is invalid:

  • expected the bug to target the "4.5.z" release, but it targets "4.6.0" instead
  • expected Bugzilla bug 1855224 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1855224: [release-4.5] etcd: remove etcd entries from mdns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 9, 2020
@cybertron
Copy link
Copy Markdown
Member

/bugzilla refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@cybertron: This pull request references Bugzilla bug 1855224, which is invalid:

  • expected Bugzilla bug 1855224 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cybertron
Copy link
Copy Markdown
Member

/retitle Bug 1855373: [release-4.5] etcd: remove etcd entries from mdns

@openshift-ci-robot openshift-ci-robot changed the title Bug 1855224: [release-4.5] etcd: remove etcd entries from mdns Bug 1855373: [release-4.5] etcd: remove etcd entries from mdns Jul 9, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1855373, which is invalid:

  • expected the bug to target the "4.5.z" release, but it targets "4.6.0" instead
  • expected dependent Bugzilla bug 1855224 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1855373: [release-4.5] etcd: remove etcd entries from mdns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cybertron
Copy link
Copy Markdown
Member

Fixed the target release in the 4.5 bz, but the 4.6 one will need to be verified before this can proceed.

@cybertron
Copy link
Copy Markdown
Member

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 15, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@cybertron: This pull request references Bugzilla bug 1855373, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1855224 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1855224 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cybertron
Copy link
Copy Markdown
Member

/retest

@mandre
Copy link
Copy Markdown
Member

mandre commented Jul 15, 2020

/test e2e-openstack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@mandre: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test e2e-aws
  • /test e2e-aws-disruptive
  • /test e2e-aws-scaleup-rhel7
  • /test e2e-azure
  • /test e2e-gcp-op
  • /test e2e-gcp-upgrade
  • /test e2e-metal-ipi
  • /test e2e-ovirt
  • /test e2e-ovn-step-registry
  • /test e2e-vsphere
  • /test e2e-vsphere-upi
  • /test images
  • /test unit
  • /test verify

Use /test all to run the following jobs:

  • pull-ci-openshift-machine-config-operator-release-4.5-e2e-aws
  • pull-ci-openshift-machine-config-operator-release-4.5-e2e-aws-scaleup-rhel7
  • pull-ci-openshift-machine-config-operator-release-4.5-e2e-gcp-op
  • pull-ci-openshift-machine-config-operator-release-4.5-e2e-gcp-upgrade
  • pull-ci-openshift-machine-config-operator-release-4.5-e2e-metal-ipi
  • pull-ci-openshift-machine-config-operator-release-4.5-e2e-ovn-step-registry
  • pull-ci-openshift-machine-config-operator-release-4.5-images
  • pull-ci-openshift-machine-config-operator-release-4.5-unit
  • pull-ci-openshift-machine-config-operator-release-4.5-verify
Details

In response to this:

/test e2e-openstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice kikisdeliveryservice changed the title Bug 1855373: [release-4.5] etcd: remove etcd entries from mdns Bug 1855373: etcd: remove etcd entries from mdns Jul 28, 2020
@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

/retest

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

This PR still needs approvals for backport, baremetal & friends

cc:
@patrickdillon @hardys @mandre @rgolangh

@rgolangh
Copy link
Copy Markdown
Contributor

Thanks for that cleanup 🥇
lgtm ovirt.

@mandre
Copy link
Copy Markdown
Member

mandre commented Jul 29, 2020

/test e2e-openstack

3 similar comments
@mandre
Copy link
Copy Markdown
Member

mandre commented Jul 29, 2020

/test e2e-openstack

@mandre
Copy link
Copy Markdown
Member

mandre commented Jul 29, 2020

/test e2e-openstack

@mandre
Copy link
Copy Markdown
Member

mandre commented Jul 30, 2020

/test e2e-openstack

@mandre
Copy link
Copy Markdown
Member

mandre commented Jul 30, 2020

Openstack finally green 👍

@cgwalters
Copy link
Copy Markdown
Member

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020
@cybertron
Copy link
Copy Markdown
Member

/test e2e-vsphere

@cybertron
Copy link
Copy Markdown
Member

/lgtm

The vsphere job hasn't passed in a while, and it looks like the cluster mostly stood up successfully.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, cybertron, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

/skip

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

cc: @ashcrow

@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 13, 2020
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 17, 2020

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere 0547845 link /test e2e-vsphere

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit bb9d3a9 into openshift:release-4.5 Aug 17, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1917. Bugzilla bug 1855373 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1855373: etcd: remove etcd entries from mdns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants