Bug 1840366: [baremetal] Switch to /readyz for haproxy healthchecking

[EgorLu]

This is a backport of the 4.5 fix #1724 by @cybertron
(cherry picked from commit 022933c)

Per [0], the /readyz endpoint is how the api communicates that it
is gracefully shutting down. Once /readyz starts to report failure,
we want to stop sending traffic to that backend. If we wait for
/healthz, it may be too late because once /healthz starts failing
the api is already not accepting connections.

I also moved the liveness probe for haproxy itself to use a /readyz
endpoint for consistency. This isn't strictly necessary, but I think
it will be less confusing if there aren't multiple health check
endpoints in the config.

0: openshift/installer#3537

[openshift-ci-robot]

@EgorLu: This pull request references Bugzilla bug 1840366, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.4.z) matches configured target release for branch (4.4.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1837676 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
• dependent Bugzilla bug 1837676 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
• bug has dependents

Details

In response to this:

Bug 1840366: [baremetal] Switch to /readyz for haproxy healthchecking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[EgorLu]

/assign @sinnykumari

[sinnykumari]

/assign @cybertron

[cybertron]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, EgorLu, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cybertron]

/test e2e-metal-ipi

[sdodson]

/bugzilla refresh

[openshift-ci-robot]

@sdodson: This pull request references Bugzilla bug 1840366, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.4.z) matches configured target release for branch (4.4.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1837676 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
• dependent Bugzilla bug 1837676 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
• bug has dependents

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@EgorLu: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1997. Bugzilla bug 1840366 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1840366: [baremetal] Switch to /readyz for haproxy healthchecking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.