Skip to content

Bug 1870285: OpenStack: Ensure resolv.conf exists before running podman#2012

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.5from
mandre:bug1853298-4.5
Aug 27, 2020
Merged

Bug 1870285: OpenStack: Ensure resolv.conf exists before running podman#2012
openshift-merge-robot merged 1 commit intoopenshift:release-4.5from
mandre:bug1853298-4.5

Conversation

@mandre
Copy link
Copy Markdown
Member

@mandre mandre commented Aug 19, 2020

Manual backport of
#1773 to
release-4.5 because of merge conflict. We can't share the prepender
script between control plane and compute nodes in OpenStack due to
dependency on the DNS VIP.

This basically boils down to porting
#1765 to the
openstack worker prepender script that was forgotten in the initial
commit.

VShpere counterpart doesn't run podman and hence doesn't need the patch.

Manual backport of
openshift#1773 to
release-4.5 because of merge conflict. We can't share the prepender
script between control plane and compute nodes in OpenStack due to
dependency on the DNS VIP.

This basically boils down to porting
openshift#1765 to the
openstack worker prepender script that was forgotten in the initial
commit.

VShpere counterpart doesn't run podman and hence doesn't need the patch.
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Aug 19, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@mandre: This pull request references Bugzilla bug 1870285, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1853298 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1853298 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents
Details

In response to this:

Bug 1870285: OpenStack: Ensure resolv.conf exists before running podman

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 19, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2020
@mandre
Copy link
Copy Markdown
Member Author

mandre commented Aug 20, 2020

/test e2e-openstack

@mandre
Copy link
Copy Markdown
Member Author

mandre commented Aug 24, 2020

/assign @pierreprinetti @Fedosin

Copy link
Copy Markdown
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@mandre mandre changed the title Bug 1870285: OpenStack: Ensure resolv.conf exists before running podman [release-4.5] Bug 1870285: OpenStack: Ensure resolv.conf exists before running podman Aug 26, 2020
@crawford crawford added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 26, 2020
@crawford crawford changed the title [release-4.5] Bug 1870285: OpenStack: Ensure resolv.conf exists before running podman Bug 1870285: OpenStack: Ensure resolv.conf exists before running podman Aug 26, 2020
@openshift-merge-robot openshift-merge-robot merged commit c4c8689 into openshift:release-4.5 Aug 27, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@mandre: All pull requests linked via external trackers have merged:

Bugzilla bug 1870285 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1870285: OpenStack: Ensure resolv.conf exists before running podman

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants