[WIP] Bug 1875005: On-Prem: No longer check for apiserver in keepalived#2070
[WIP] Bug 1875005: On-Prem: No longer check for apiserver in keepalived#2070mandre wants to merge 1 commit intoopenshift:masterfrom
Conversation
There is no good reason for keepalived to query the kube-apiserver for its liveliness since all requests are proxied by haproxy anyway that balances the requests among backends in a roundrobin fashion. Keepalived should only care about the status of the local HAProxy instance, and HAProxy should be the one to care about the backend status. Having keepalived check for API status causes frequent failovers and connection drops when the API is a bit busy.
|
@mandre: This pull request references Bugzilla bug 1875005, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test e2e-openstack |
|
@mandre: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Hmm, we still need to look at the api status otherwise we may move the VIP to the master nodes too early and bootstrap doesn't finish. I just found out it might have already been addressed on BM with #1893. /close |
|
@mandre: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mandre: This pull request references Bugzilla bug 1875005. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There is no good reason for keepalived to query the kube-apiserver for
its liveliness since all requests are proxied by haproxy anyway that
balances the requests among backends in a roundrobin fashion. Keepalived
should only care about the status of the local HAProxy instance, and
HAProxy should be the one to care about the backend status.
Having keepalived check for API status causes frequent failovers and
connection drops when the API is a bit busy.