Skip to content

[WIP] Bug 1875005: On-Prem: No longer check for apiserver in keepalived#2070

Closed
mandre wants to merge 1 commit intoopenshift:masterfrom
mandre:on-prem-keepalived-check
Closed

[WIP] Bug 1875005: On-Prem: No longer check for apiserver in keepalived#2070
mandre wants to merge 1 commit intoopenshift:masterfrom
mandre:on-prem-keepalived-check

Conversation

@mandre
Copy link
Copy Markdown
Member

@mandre mandre commented Sep 10, 2020

There is no good reason for keepalived to query the kube-apiserver for
its liveliness since all requests are proxied by haproxy anyway that
balances the requests among backends in a roundrobin fashion. Keepalived
should only care about the status of the local HAProxy instance, and
HAProxy should be the one to care about the backend status.

Having keepalived check for API status causes frequent failovers and
connection drops when the API is a bit busy.

There is no good reason for keepalived to query the kube-apiserver for
its liveliness since all requests are proxied by haproxy anyway that
balances the requests among backends in a roundrobin fashion. Keepalived
should only care about the status of the local HAProxy instance, and
HAProxy should be the one to care about the backend status.

Having keepalived check for API status causes frequent failovers and
connection drops when the API is a bit busy.
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. labels Sep 10, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@mandre: This pull request references Bugzilla bug 1875005, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

[WIP] Bug 1875005: On-Prem: No longer check for apiserver in keepalived

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 10, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2020
@mandre
Copy link
Copy Markdown
Member Author

mandre commented Sep 10, 2020

/test e2e-openstack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@mandre: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack 5a2307e link /test e2e-openstack
ci/prow/okd-e2e-aws 5a2307e link /test okd-e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandre
Copy link
Copy Markdown
Member Author

mandre commented Sep 10, 2020

Hmm, we still need to look at the api status otherwise we may move the VIP to the master nodes too early and bootstrap doesn't finish.

I just found out it might have already been addressed on BM with #1893.

/close

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@mandre: Closed this PR.

Details

In response to this:

Hmm, we still need to look at the api status otherwise we may move the VIP to the master nodes too early and bootstrap doesn't finish.

I just found out it might have already been addressed on BM with #1893.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@mandre: This pull request references Bugzilla bug 1875005. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

[WIP] Bug 1875005: On-Prem: No longer check for apiserver in keepalived

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants