Dedupe on-prem bootstrap manifests by bcrochet · Pull Request #2071 · openshift/machine-config-operator

bcrochet · 2020-09-10T15:51:29Z

- What I did
Currently, all of the on-prem platforms duplicate the manifests needed for
bootstrap. There is a small difference in all of them, and these can be
gotten rid of by moving some of the template code into functions in Go.

- How to verify it
Verify that on-prem platforms can still deploy.

- Description for the changelog

Dedupe bootstrap manifests for on-prem platforms.

mandre · 2020-09-10T16:05:18Z

/test e2e-openstack
/test e2e-ovirt
/test e2e-vsphere

cgwalters

/approve
the idea in general (and we should likely do the same with the kubelet systemd unit).

But this is a nontrivial change without an immediate bug it's fixing (right?) so I'm adding the 4.7 label.

bcrochet · 2020-09-10T17:11:47Z

/approve
the idea in general (and we should likely do the same with the kubelet systemd unit).

But this is a nontrivial change without an immediate bug it's fixing (right?) so I'm adding the 4.7 label.

You are correct. Thanks!

bcrochet · 2020-09-10T18:38:12Z

/test e2e-metal-ipi
/test e2e-ovirt
/test e2e-openstack
/test e2e-vsphere
/test e2e-aws

bcrochet · 2020-09-11T16:03:30Z

/retest

cybertron

Cool, this is a big improvement! A couple of things inline.

bcrochet · 2020-09-14T12:05:37Z

/retest

ravidbro · 2020-09-14T13:37:45Z

I'm thrilled to see that.
Are we planning to do the same also for the templates?

bcrochet · 2020-09-14T13:39:45Z

I'm thrilled to see that.
Are we planning to do the same also for the templates?

See #2079

cybertron

/lgtm

openshift-bot · 2020-09-14T14:14:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-14T14:27:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

cybertron · 2020-09-14T14:31:17Z

/lgtm cancel

I don't think we want the bot to sit here and retest until 4.7 opens.

bcrochet · 2020-09-17T16:49:39Z

/retest

bcrochet · 2020-10-12T13:43:09Z

/retest

bcrochet · 2020-10-12T14:37:03Z

/test e2e-ovirt
/test e2e-openstack
/test e2e-vsphere

openshift-ci-robot · 2020-10-12T16:33:26Z

@bcrochet: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-upgrade	702e63716ca74d0e575668877acb5222df799f38	link	`/test e2e-gcp-upgrade`
ci/prow/e2e-aws-workers-rhel7	4771fc3705391fdab825d034674d54441f185453	link	`/test e2e-aws-workers-rhel7`
ci/prow/e2e-openstack	4771fc3705391fdab825d034674d54441f185453	link	`/test e2e-openstack`
ci/prow/e2e-ovirt	4771fc3705391fdab825d034674d54441f185453	link	`/test e2e-ovirt`
ci/prow/e2e-aws	4771fc3705391fdab825d034674d54441f185453	link	`/test e2e-aws`
ci/prow/e2e-ovn-step-registry	4771fc3705391fdab825d034674d54441f185453	link	`/test e2e-ovn-step-registry`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

bcrochet · 2020-10-15T14:03:14Z

/retest

Currently, all of the on-prem platforms duplicate the manifests needed for bootstrap. There is a small difference in all of them, and these can be gotten rid of by moving some of the template code into functions in Go.

ravidbro · 2020-10-27T07:39:38Z

/test e2e-ovirt

ravidbro · 2020-10-27T07:39:49Z

/test e2e-gcp-op

ravidbro · 2020-10-27T07:40:01Z

/test e2e-agnostic-upgrade

ravidbro · 2020-10-27T07:40:11Z

/test okd-e2e-aws

ravidbro · 2020-10-27T07:40:23Z

/test e2e-aws

ravidbro · 2020-10-27T09:26:39Z

/test okd-e2e-aws

ravidbro · 2020-10-27T10:04:30Z

/test e2e-gcp-op

ravidbro · 2020-10-27T11:10:04Z

/test okd-e2e-aws

bcrochet · 2020-10-28T19:30:13Z

/retest

ravidbro · 2020-10-29T07:13:14Z

/test e2e-gcp-op

ravidbro · 2020-10-29T14:03:03Z

/lgtm

openshift-ci-robot · 2020-10-29T14:03:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bcrochet, cgwalters, ravidbro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [cgwalters]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cgwalters · 2020-10-29T17:23:15Z

Thanks for pushing this through!

openshift-ci-robot requested review from ashcrow and ericavonb September 10, 2020 15:52

ashcrow requested review from sinnykumari and removed request for ashcrow September 10, 2020 16:49

cgwalters added the 4.7 Work deferred for 4.7 label Sep 10, 2020

cgwalters approved these changes Sep 10, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2020

cybertron suggested changes Sep 11, 2020

View reviewed changes

Comment thread pkg/operator/render.go Outdated

Comment thread pkg/operator/render.go Outdated

Comment thread pkg/operator/render.go Outdated

bcrochet force-pushed the manifest-dedupe branch 2 times, most recently from 7851af9 to 702e637 Compare September 11, 2020 22:16

cybertron approved these changes Sep 14, 2020

View reviewed changes

openshift-ci-robot assigned cybertron Sep 14, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2020

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2020

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2020

bcrochet force-pushed the manifest-dedupe branch from 702e637 to 4771fc3 Compare October 12, 2020 12:02

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2020

Dedupe on-prem bootstrap manifests

eb9ee78

Currently, all of the on-prem platforms duplicate the manifests needed for bootstrap. There is a small difference in all of them, and these can be gotten rid of by moving some of the template code into functions in Go.

bcrochet force-pushed the manifest-dedupe branch from 4771fc3 to eb9ee78 Compare October 26, 2020 14:38

openshift-ci-robot assigned ravidbro Oct 29, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2020

ravidbro removed their assignment Oct 29, 2020

openshift-merge-robot merged commit 2299f82 into openshift:master Oct 29, 2020

ravidbro mentioned this pull request Nov 1, 2020

Add kubevirt platform #2098

Merged

Conversation

bcrochet commented Sep 10, 2020

Uh oh!

mandre commented Sep 10, 2020

Uh oh!

cgwalters left a comment

Choose a reason for hiding this comment

Uh oh!

bcrochet commented Sep 10, 2020

Uh oh!

bcrochet commented Sep 10, 2020

Uh oh!

bcrochet commented Sep 11, 2020

Uh oh!

cybertron left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bcrochet commented Sep 14, 2020

Uh oh!

ravidbro commented Sep 14, 2020

Uh oh!

bcrochet commented Sep 14, 2020

Uh oh!

cybertron left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Sep 14, 2020

Uh oh!

openshift-bot commented Sep 14, 2020

Uh oh!

cybertron commented Sep 14, 2020

Uh oh!

bcrochet commented Sep 17, 2020

Uh oh!

bcrochet commented Oct 12, 2020

Uh oh!

bcrochet commented Oct 12, 2020

Uh oh!

openshift-ci-robot commented Oct 12, 2020

Uh oh!

bcrochet commented Oct 15, 2020

Uh oh!

ravidbro commented Oct 27, 2020

Uh oh!

ravidbro commented Oct 27, 2020

Uh oh!

ravidbro commented Oct 27, 2020

Uh oh!

ravidbro commented Oct 27, 2020

Uh oh!

ravidbro commented Oct 27, 2020

Uh oh!

ravidbro commented Oct 27, 2020

Uh oh!

ravidbro commented Oct 27, 2020

Uh oh!

ravidbro commented Oct 27, 2020

Uh oh!

bcrochet commented Oct 28, 2020

Uh oh!

ravidbro commented Oct 29, 2020

Uh oh!

ravidbro commented Oct 29, 2020

Uh oh!

openshift-ci-robot commented Oct 29, 2020

Uh oh!

cgwalters commented Oct 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants