Skip to content

[WIP] Rearrange template for the external cloud-provider#2093

Closed
Danil-Grigorev wants to merge 2 commits intoopenshift:masterfrom
Danil-Grigorev:external-provider-support
Closed

[WIP] Rearrange template for the external cloud-provider#2093
Danil-Grigorev wants to merge 2 commits intoopenshift:masterfrom
Danil-Grigorev:external-provider-support

Conversation

@Danil-Grigorev
Copy link
Copy Markdown

- What I did

Skip cloud flags for the kubelet configuration

- How to verify it

TBD

- Description for the changelog

TBD

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Danil-Grigorev
To complete the pull request process, please assign runcom
You can assign the PR to them by writing /assign @runcom in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2020
@Danil-Grigorev Danil-Grigorev force-pushed the external-provider-support branch from fac6c8b to 8ace206 Compare September 17, 2020 09:44
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2020
@Danil-Grigorev Danil-Grigorev force-pushed the external-provider-support branch from 8ace206 to e41889b Compare September 18, 2020 07:27
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 18, 2020

@Danil-Grigorev: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-aws e41889b link /test okd-e2e-aws
ci/prow/e2e-metal-ipi e41889b link /test e2e-metal-ipi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@Danil-Grigorev: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

@Danil-Grigorev: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-agnostic-upgrade e41889b link /test e2e-agnostic-upgrade
ci/prow/e2e-aws-serial e41889b link /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

This hasn't had any work since september - please reopen if necessary.

@Danil-Grigorev
Copy link
Copy Markdown
Author

/reopen

Just got this tackled in proposal - slightly different approach. This needs to run CCM in openshift, and disable cloud-provider specific flags - https://github.com/openshift/enhancements/pull/463/files#diff-3e0e2c48e70215076dfe36c13768a823ab7080d929d80292f37db2ef5a2121e8R201

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@Danil-Grigorev: Failed to re-open PR: state cannot be changed. The external-provider-support branch was force-pushed or recreated.

Details

In response to this:

/reopen

Just got this tackled in proposal - slightly different approach. This needs to run CCM in openshift, and disable cloud-provider specific flags - https://github.com/openshift/enhancements/pull/463/files#diff-3e0e2c48e70215076dfe36c13768a823ab7080d929d80292f37db2ef5a2121e8R201

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Danil-Grigorev
Copy link
Copy Markdown
Author

Reopened in a new PR: #2386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants