[WIP] Rearrange template for the external cloud-provider#2093
[WIP] Rearrange template for the external cloud-provider#2093Danil-Grigorev wants to merge 2 commits intoopenshift:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Danil-Grigorev The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
fac6c8b to
8ace206
Compare
8ace206 to
e41889b
Compare
|
@Danil-Grigorev: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@Danil-Grigorev: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Danil-Grigorev: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This hasn't had any work since september - please reopen if necessary. |
|
/reopen Just got this tackled in proposal - slightly different approach. This needs to run CCM in openshift, and disable cloud-provider specific flags - https://github.com/openshift/enhancements/pull/463/files#diff-3e0e2c48e70215076dfe36c13768a823ab7080d929d80292f37db2ef5a2121e8R201 |
|
@Danil-Grigorev: Failed to re-open PR: state cannot be changed. The external-provider-support branch was force-pushed or recreated. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Reopened in a new PR: #2386 |
- What I did
Skip cloud flags for the kubelet configuration
- How to verify it
TBD
- Description for the changelog
TBD