Skip to content

[wip] vsphere - excessive vip migration#2138

Closed
jcpowermac wants to merge 1 commit intoopenshift:release-4.6from
jcpowermac:vsphere_try_noprempt
Closed

[wip] vsphere - excessive vip migration#2138
jcpowermac wants to merge 1 commit intoopenshift:release-4.6from
jcpowermac:vsphere_try_noprempt

Conversation

@jcpowermac
Copy link
Copy Markdown
Contributor

trying to use nopreempt to resolve vip migration

trying to use nopreempt to resolve vip migration
@jcpowermac jcpowermac changed the title vsphere - excessive vip migration [wip] vsphere - excessive vip migration Oct 2, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcpowermac
To complete the pull request process, please assign kikisdeliveryservice after the PR has been reviewed.
You can assign the PR to them by writing /assign @kikisdeliveryservice in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcpowermac
Copy link
Copy Markdown
Contributor Author

/test e2e-vsphere

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@jcpowermac: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere 863d782 link /test e2e-vsphere
ci/prow/cluster-bootimages 863d782 link /test cluster-bootimages
ci/prow/e2e-gcp-op 863d782 link /test e2e-gcp-op
ci/prow/e2e-aws 863d782 link /test e2e-aws
ci/prow/e2e-ovn-step-registry 863d782 link /test e2e-ovn-step-registry
ci/prow/e2e-metal-ipi 863d782 link /test e2e-metal-ipi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yboaron
Copy link
Copy Markdown
Contributor

yboaron commented Oct 4, 2020

Because we use two track scripts to set Keepalived instance priority I think we might see unexpected behavior when nopreempt is set, for example an instance with 2 successful scripts won't preempt an instance with a single successful script .
So I'm not sure if nopreempt is a good idea with the current Keepalived track scripts config.

see [1]

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1870177

@mandre
Copy link
Copy Markdown
Member

mandre commented Oct 5, 2020

We were also experiencing high failover rate with keepalived on openstack platform and ended up solving it with #2077 and #2091.

@jcpowermac
Copy link
Copy Markdown
Contributor Author

Thanks @mandre and @yboaron.

Just going to close this pr and deal with the issue in CI.

@jcpowermac
Copy link
Copy Markdown
Contributor Author

/close

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@jcpowermac: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants