Update hostname when transient hostname is fedora#2158
Update hostname when transient hostname is fedora#2158bdurrow wants to merge 1 commit intoopenshift:fcosfrom
Conversation
A recent change, perhaps the adoption of fcos 33 broke hostname assignment (at least in GCP) because the transient hostname was set to fedora on boot. We need to use the dhcp provided hostname in this case.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bdurrow The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @bdurrow. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Sorry for confusion, but |
|
Verified that this fix works on OKD 4.6 in GCP. However its odd that default hostname is |
|
Rebased in #2160 |
A recent change, perhaps the adoption of fcos 33 broke hostname assignment (at least in GCP) because the transient hostname was set to fedora on boot. We need to use the dhcp provided hostname in this case.
- What I did
Modified templates/common/_base/files/etc-networkmanager-dispatcher.d-90-long-hostname.yaml so that the string fedora is treated like localhost when we check to see if the hostname was previously set.
- How to verify it
Build a 4.6 cluster in GCP.
- Description for the changelog
Use dhcp provided hostname when transient hostname is fedora