templates: move recycler pod out of kubelet manifests directory

[sjenning]

xref https://bugzilla.redhat.com/show_bug.cgi?id=1896226

This is the first step in resolving a bug introduced by #1687 and openshift/cluster-kube-controller-manager-operator#405

/etc/kubernetes/manifests is the kubelet's static pod manifests directory. The kubelet will try to start pods defined in this location as static pods. The recycler pod is not a static pod and the kubelet continuously fails to start it.

The solution is to move the recycler pod manifests to a different directory.

The fix is a 3-step process (as I see it):

• Change location of the recycler pod in the MCO template (this PR)
• Change KCM to use the new location
• Delete (or empty out) the file in the old location

@runcom @sttts @rphillips

[sjenning]

also @haircommander

[sjenning]

Indeed the old file still needs to be there

F1118 21:07:22.756911       1 plugins.go:123] Could not create hostpath recycler pod from file /etc/kubernetes/manifests/recycler-pod.yaml: failed to read file path /etc/kubernetes/manifests/recycler-pod.yaml: open /etc/kubernetes/manifests/recycler-pod.yaml: no such file or directory

[sjenning]

/retest

[JAORMX]

/retest

[sjenning]

/retest

[cgwalters]

OK I see, and it's then configured by the other pod.
/approve
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, JAORMX, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [cgwalters]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cgwalters]

It'd be good I think to change https://github.com/openshift/cluster-kube-controller-manager-operator to detect the path dynamically - that would avoid a version interlock between the these two codebases and make backporting easier.

(i.e. mount /etc/kubernetes into the pod and check for both files, preferring the one in /etc/kubernetes)

Also this file would be another good one to add to this #2232 (comment)

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-merge-robot]

@sjenning: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/okd-e2e-aws	9790e1d	link	/test okd-e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.