Bug 1908648: [test] Skip TestKernelType on OKD by LorbusChris · Pull Request #2256 · openshift/machine-config-operator

LorbusChris · 2020-11-25T13:11:45Z

Adds an isOKDCluster function to determine whether the current cluster
is an OKD cluster.

Skips TestKernelType on OKD because the realtime kernel is not available
on OKD clusters.

LorbusChris · 2020-11-25T13:14:01Z

/test ci/prow/okd-e2e-gcp-op

openshift-ci-robot · 2020-11-25T13:14:19Z

@LorbusChris: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test cluster-bootimages
/test e2e-agnostic-upgrade
/test e2e-aws
/test e2e-aws-disruptive
/test e2e-aws-proxy
/test e2e-aws-serial
/test e2e-aws-workers-rhel7
/test e2e-azure
/test e2e-gcp-op
/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-dualstack
/test e2e-openstack
/test e2e-ovirt
/test e2e-ovn-step-registry
/test e2e-vsphere
/test e2e-vsphere-upi
/test images
/test okd-e2e-aws
/test okd-e2e-gcp-op
/test okd-e2e-upgrade
/test okd-images
/test unit
/test verify

Use /test all to run the following jobs:

pull-ci-openshift-machine-config-operator-master-e2e-agnostic-upgrade
pull-ci-openshift-machine-config-operator-master-e2e-aws
pull-ci-openshift-machine-config-operator-master-e2e-aws-serial
pull-ci-openshift-machine-config-operator-master-e2e-aws-workers-rhel7
pull-ci-openshift-machine-config-operator-master-e2e-gcp-op
pull-ci-openshift-machine-config-operator-master-e2e-metal-ipi
pull-ci-openshift-machine-config-operator-master-e2e-ovn-step-registry
pull-ci-openshift-machine-config-operator-master-images
pull-ci-openshift-machine-config-operator-master-okd-e2e-aws
pull-ci-openshift-machine-config-operator-master-okd-images
pull-ci-openshift-machine-config-operator-master-unit
pull-ci-openshift-machine-config-operator-master-verify

Details

In response to this:

/test ci/prow/okd-e2e-gcp-op

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LorbusChris · 2020-11-25T13:16:28Z

/test okd-e2e-gcp-op

LorbusChris · 2020-11-25T18:30:47Z

couldn't pull images from quay due to an outage - should be resolved now
/retest

LorbusChris · 2020-11-25T22:00:43Z

I'll rework this
/hold
/retitle WIP: [test] Skip TestKernelType on OKD

Adds an isOKDCluster function to determine whether the current cluster is an OKD cluster. Skips TestKernelType on OKD because the realtime kernel is not available on OKD clusters.

LorbusChris · 2020-12-01T10:15:27Z

/test okd-e2e-gcp-op

LorbusChris · 2020-12-01T14:58:14Z

/test okd-e2e-gcp-op
/retest

LorbusChris · 2020-12-01T17:45:30Z

/test okd-e2e-gcp-op

LorbusChris · 2020-12-01T18:07:58Z

/test okd-e2e-gcp-op

LorbusChris · 2020-12-01T20:30:04Z

/test okd-e2e-gcp-op

LorbusChris · 2020-12-01T22:40:40Z

/test okd-e2e-gcp-op

LorbusChris · 2020-12-01T23:36:09Z

/test okd-e2e-gcp-op

LorbusChris · 2020-12-02T06:54:14Z

/test okd-e2e-gcp-op

LorbusChris · 2020-12-02T09:27:06Z

/test okd-e2e-aws

LorbusChris · 2020-12-02T11:42:23Z

/test okd-e2e-aws

LorbusChris · 2020-12-03T14:43:09Z

/retest
/test okd-e2e-gcp-op

LorbusChris · 2020-12-03T22:22:41Z

/test okd-e2e-gcp-op

LorbusChris · 2020-12-04T00:34:47Z

@vrutkovs this now fails at TestExtensions since we don't ship usbguard and kernel-devel in the extensions yum repo in OKD's machine-os-content.

Let's ship them there instead of skipping this test as well (while not installing them by default).

sinnykumari · 2020-12-17T08:53:07Z

/assign @vrutkovs

vrutkovs

/lgtm

🥳

sinnykumari · 2020-12-17T09:14:00Z

@LorbusChris you can remove hold when you think it is good to go

sinnykumari · 2020-12-17T09:15:09Z

weird, lgtm label didn't get applied.

/lgtm

openshift-ci-robot · 2020-12-17T09:15:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris, sinnykumari, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sinnykumari · 2020-12-17T09:17:05Z

umm, a bug also needs to get created as we are in feature freeze

vrutkovs · 2020-12-17T09:22:30Z

/retitle Bug 1908648: [test] Skip TestKernelType on OKD

openshift-ci-robot · 2020-12-17T09:22:59Z

@LorbusChris: This pull request references Bugzilla bug 1908648, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1908648: [test] Skip TestKernelType on OKD

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LorbusChris · 2020-12-17T18:09:37Z

this works, lifting the hold
/hold cancel

openshift-bot · 2020-12-17T20:05:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-17T20:44:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-17T22:02:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

kikisdeliveryservice · 2020-12-17T23:22:10Z

So okd-e2e-gcp-op is now passing okd-e2e-aws is passing e2e-gcp-op is passing and this PR only changes files in /test/e2e so I'm overriding e2e-aws-serial/e2e-aws/e2e-agnostic-upgrade bc they are unaffected by this pr and okd having functioning ci is important.

/override ci/prow/e2e-agnostic-upgrade
/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-serial

openshift-ci-robot · 2020-12-17T23:22:36Z

@kikisdeliveryservice: Overrode contexts on behalf of kikisdeliveryservice: ci/prow/e2e-agnostic-upgrade, ci/prow/e2e-aws, ci/prow/e2e-aws-serial

Details

In response to this:

So okd-e2e-gcp-op is now passing okd-e2e-aws is passing e2e-gcp-op is passing and this PR only changes files in /test/e2e so I'm overriding e2e-aws-serial/e2e-aws/e2e-agnostic-upgrade bc they are unaffected by this pr and okd having functioning ci is important.

/override ci/prow/e2e-agnostic-upgrade
/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kikisdeliveryservice · 2020-12-17T23:31:25Z

Also ftr modified tests were run in the e2e-gcp-op job so no regression there.:
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/2256/pull-ci-openshift-machine-config-operator-master-e2e-gcp-op/1339634970741706752/artifacts/e2e-gcp-op/test/container-logs/test.log

kikisdeliveryservice · 2020-12-17T23:49:57Z

One more time bot:

/override ci/prow/e2e-aws

openshift-ci-robot · 2020-12-17T23:50:18Z

@kikisdeliveryservice: Overrode contexts on behalf of kikisdeliveryservice: ci/prow/e2e-aws

Details

In response to this:

One more time bot:

/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LorbusChris · 2020-12-18T00:06:25Z

Thank you @kikisdeliveryservice!

/cherry-pick release-4.6
so we can get OKD tests on 4.6 working again..

openshift-cherrypick-robot · 2020-12-18T00:06:25Z

@LorbusChris: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

Details

In response to this:

Thank you @kikisdeliveryservice!

/cherry-pick release-4.6
so we can get OKD tests on 4.6 working again..

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-12-18T01:28:29Z

@LorbusChris: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#2256

Bugzilla bug 1908648 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1908648: [test] Skip TestKernelType on OKD

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-12-18T01:28:46Z

@LorbusChris: new pull request created: #2311

Details

In response to this:

Thank you @kikisdeliveryservice!

/cherry-pick release-4.6
so we can get OKD tests on 4.6 working again..

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from kikisdeliveryservice and runcom November 25, 2020 13:12

cgwalters reviewed Nov 25, 2020

View reviewed changes

Comment thread test/e2e/utils_test.go Outdated

cgwalters reviewed Nov 25, 2020

View reviewed changes

Comment thread test/e2e/mcd_test.go Outdated

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2020

openshift-ci-robot changed the title ~~[test] Skip TestKernelType on OKD~~ WIP: [test] Skip TestKernelType on OKD Nov 25, 2020

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2020

[test] Skip TestKernelType on OKD

eb47ae0

Adds an isOKDCluster function to determine whether the current cluster is an OKD cluster. Skips TestKernelType on OKD because the realtime kernel is not available on OKD clusters.

LorbusChris force-pushed the okd-skip-tests branch from a2ae220 to eb47ae0 Compare December 1, 2020 10:13

LorbusChris changed the title ~~WIP: [test] Skip TestKernelType on OKD~~ [test] Skip TestKernelType on OKD Dec 1, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2020

vrutkovs mentioned this pull request Dec 7, 2020

Bug 1904825: [release-4.6] templates: Set vSphere hostname from guestinfo before NM starts #2289

Merged

openshift-ci-robot assigned vrutkovs Dec 17, 2020

vrutkovs approved these changes Dec 17, 2020

View reviewed changes

openshift-ci-robot assigned sinnykumari Dec 17, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2020

openshift-ci-robot changed the title ~~[test] Skip TestKernelType on OKD~~ Bug 1908648: [test] Skip TestKernelType on OKD Dec 17, 2020

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 17, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2020

openshift-merge-robot merged commit ca283c2 into openshift:master Dec 18, 2020

openshift-cherrypick-robot mentioned this pull request Dec 18, 2020

[release-4.6] Bug 1908940: [test] Skip TestKernelType on OKD #2311

Merged

Conversation

LorbusChris commented Nov 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LorbusChris commented Nov 25, 2020

Uh oh!

openshift-ci-robot commented Nov 25, 2020

Uh oh!

LorbusChris commented Nov 25, 2020

Uh oh!

LorbusChris commented Nov 25, 2020

Uh oh!

Uh oh!

Uh oh!

LorbusChris commented Nov 25, 2020

Uh oh!

LorbusChris commented Dec 1, 2020

Uh oh!

LorbusChris commented Dec 1, 2020

Uh oh!

LorbusChris commented Dec 1, 2020

Uh oh!

LorbusChris commented Dec 1, 2020

Uh oh!

LorbusChris commented Dec 1, 2020

Uh oh!

LorbusChris commented Dec 1, 2020

Uh oh!

LorbusChris commented Dec 1, 2020

Uh oh!

LorbusChris commented Dec 2, 2020

Uh oh!

LorbusChris commented Dec 2, 2020

Uh oh!

LorbusChris commented Dec 2, 2020

Uh oh!

LorbusChris commented Dec 3, 2020

Uh oh!

LorbusChris commented Dec 3, 2020

Uh oh!

LorbusChris commented Dec 4, 2020

Uh oh!

sinnykumari commented Dec 17, 2020

Uh oh!

vrutkovs left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sinnykumari commented Dec 17, 2020

Uh oh!

sinnykumari commented Dec 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Dec 17, 2020

Uh oh!

sinnykumari commented Dec 17, 2020

Uh oh!

vrutkovs commented Dec 17, 2020

Uh oh!

openshift-ci-robot commented Dec 17, 2020

Uh oh!

LorbusChris commented Dec 17, 2020

Uh oh!

openshift-bot commented Dec 17, 2020

Uh oh!

openshift-bot commented Dec 17, 2020

Uh oh!

openshift-bot commented Dec 17, 2020

Uh oh!

kikisdeliveryservice commented Dec 17, 2020

Uh oh!

openshift-ci-robot commented Dec 17, 2020

Uh oh!

kikisdeliveryservice commented Dec 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kikisdeliveryservice commented Dec 17, 2020

Uh oh!

openshift-ci-robot commented Dec 17, 2020

Uh oh!

LorbusChris commented Nov 25, 2020 •

edited

Loading

vrutkovs left a comment •

edited

Loading

sinnykumari commented Dec 17, 2020 •

edited

Loading

kikisdeliveryservice commented Dec 17, 2020 •

edited

Loading