Skip to content

WIP: Ignore CSIMigrationControlPlane FeatureSet#2371

Closed
bertinatto wants to merge 2 commits intoopenshift:masterfrom
bertinatto:csi-migration
Closed

WIP: Ignore CSIMigrationControlPlane FeatureSet#2371
bertinatto wants to merge 2 commits intoopenshift:masterfrom
bertinatto:csi-migration

Conversation

@bertinatto
Copy link
Copy Markdown
Member

@bertinatto bertinatto commented Jan 29, 2021

This is a PoC implementation of openshift/enhancements#549.

Not ready for review yet.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2021
@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

kikisdeliveryservice commented Feb 8, 2021

Just as a note there is overlap on funcs touched between this pr and #2386 I believe..

@kikisdeliveryservice kikisdeliveryservice mentioned this pull request Feb 8, 2021
Merged
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 19, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bertinatto
To complete the pull request process, please assign yuqi-zhang after the PR has been reviewed.
You can assign the PR to them by writing /assign @yuqi-zhang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 19, 2021 •
edited
Loading

@bertinatto: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-aws 2589e48 link /test okd-e2e-aws
ci/prow/e2e-aws 2589e48 link /test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bertinatto
Copy link
Copy Markdown
Member Author

bertinatto commented Apr 7, 2021

We're not going to take this approach anymore.

@bertinatto bertinatto closed this Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@runcom runcom Awaiting requested review from runcom

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bertinatto @kikisdeliveryservice @openshift-ci-robot