Bug 1919271: NM resolve prepender: Update for systemd-resolved logic. systemd-resolved requires restart after dropin created by fortinj66 · Pull Request #2377 · openshift/machine-config-operator

fortinj66 · 2021-02-01T15:32:56Z

- What I did

remove OS check. If node has systemd-resolved enabled this will work
Check to see if systemd-resolved is enabled. Otherwise skip
Check if /etc/systemd/resolved.conf.d/60-kni.conf exists. If it doesn't create it and restart systemd-resolved if active
Add logging

- How to verify it

- Description for the changelog
NM resolve prepender: Update for systemd-resolved logic

- remove OS check. If node has systemd-resolved enabled this will work - Check to see if systemd-resolved is enabled. Otherwise skip - Check if /etc/systemd/resolved.conf.d/60-kni.conf exists. If it doesn't create it and restart systemd-resolved if active - Add logging

openshift-ci-robot · 2021-02-01T15:33:19Z

Hi @fortinj66. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vrutkovs · 2021-02-01T15:39:10Z

/ok-to-test

vrutkovs · 2021-02-01T15:39:59Z

/retitle Bug 1919271: NM resolve prepender: Update for systemd-resolved logic. systemd-resolved requires restart after dropin created

….yaml Co-authored-by: Vadim Rutkovsky <roignac@gmail.com>

openshift-ci-robot · 2021-02-01T15:40:20Z

@fortinj66: This pull request references Bugzilla bug 1919271, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1919271: NM resolve prepender: Update for systemd-resolved logic. systemd-resolved requires restart after dropin created

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vrutkovs · 2021-02-01T15:41:14Z

/bugzilla refresh
/test okd-e2e-vsphere
/test e2e-openstack

openshift-ci-robot · 2021-02-01T15:41:20Z

@vrutkovs: This pull request references Bugzilla bug 1919271, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh
/test okd-e2e-vsphere
/test e2e-openstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kikisdeliveryservice · 2021-02-01T17:15:59Z

/hold
/assign @bcrochet @EmilienM

vrutkovs · 2021-02-01T17:32:45Z

level=info msg=Cluster operator authentication Available is False with WellKnown_NotReady: WellKnownAvailable: The well-known endpoint is not yet available: need at least 3 kube-apiservers, got 2

master didn't come up in openstack.

/test e2e-openstack

rhel7 workers is known to be failing - missing RPM repo.
OKD tests failing on known issue - https://bugzilla.redhat.com/show_bug.cgi?id=1922991

vrutkovs · 2021-02-01T19:19:59Z

This is a followup for #2359, fixing NM/resolved races and ensures it would work on RHEL once it switches to systemd-resolved

@celebdor @jcpowermac @mandre PTAL

kikisdeliveryservice · 2021-02-01T19:25:05Z

/test e2e-vsphere

fortinj66 · 2021-02-01T22:09:04Z

/retest

fortinj66 · 2021-02-02T01:00:42Z

/retest

….yaml Co-authored-by: Martin André <martin.andre@gmail.com>

vrutkovs · 2021-02-02T12:55:49Z

/test okd-e2e-vsphere
/test e2e-openstack

vrutkovs · 2021-02-02T14:25:42Z

/test e2e-vsphere

mandre

/lgtm

cybertron · 2021-02-02T22:41:19Z

/lgtm

kikisdeliveryservice · 2021-02-03T20:15:43Z

assuming these red okd jobs are expected.

/approve
/hold cancel

openshift-ci-robot · 2021-02-03T20:15:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, fortinj66, kikisdeliveryservice, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-02-03T20:18:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

fortinj66 · 2021-02-03T20:24:58Z

according to @vrutkovs yes...

vrutkovs · 2021-02-03T20:29:24Z

OKD e2e aws should now pass (vsphere's run is more prone to flakes). I'll babysit this one

openshift-bot · 2021-02-03T21:49:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-03T22:54:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-03T23:07:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-02-04T00:44:25Z

@fortinj66: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/okd-e2e-vsphere	`da19579`	link	`/test okd-e2e-vsphere`
ci/prow/okd-e2e-aws	`da19579`	link	`/test okd-e2e-aws`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-02-04T00:51:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2021-02-04T00:55:32Z

@fortinj66: All pull requests linked via external trackers have merged:

Bugzilla bug 1919271 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1919271: NM resolve prepender: Update for systemd-resolved logic. systemd-resolved requires restart after dropin created

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from ashcrow and darkmuggle February 1, 2021 15:33

openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 1, 2021

vrutkovs reviewed Feb 1, 2021

View reviewed changes

Comment thread templates/common/on-prem/files/NetworkManager-resolv-prepender.yaml Outdated

openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 1, 2021

Update templates/common/on-prem/files/NetworkManager-resolv-prepender…

b5bee25

….yaml Co-authored-by: Vadim Rutkovsky <roignac@gmail.com>

openshift-ci-robot changed the title ~~NM resolve prepender: Update for systemd-resolved logic. systemd-resolved requires restart after dropin created~~ Bug 1919271: NM resolve prepender: Update for systemd-resolved logic. systemd-resolved requires restart after dropin created Feb 1, 2021

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 1, 2021

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 1, 2021

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 1, 2021

openshift-ci-robot assigned bcrochet Feb 1, 2021

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2021

openshift-ci-robot assigned EmilienM Feb 1, 2021

kikisdeliveryservice assigned mandre and celebdor Feb 2, 2021

mandre reviewed Feb 2, 2021

View reviewed changes

Comment thread templates/common/on-prem/files/NetworkManager-resolv-prepender.yaml Outdated

Comment thread templates/common/on-prem/files/NetworkManager-resolv-prepender.yaml Outdated

fortinj66 and others added 2 commits February 2, 2021 06:07

Update templates/common/on-prem/files/NetworkManager-resolv-prepender…

cb224eb

….yaml Co-authored-by: Martin André <martin.andre@gmail.com>

Update templates/common/on-prem/files/NetworkManager-resolv-prepender…

da19579

….yaml Co-authored-by: Martin André <martin.andre@gmail.com>

mandre reviewed Feb 2, 2021

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2021

openshift-ci-robot assigned cybertron Feb 2, 2021

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2021

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2021

openshift-merge-robot merged commit 520b149 into openshift:master Feb 4, 2021

fortinj66 mentioned this pull request Feb 9, 2021

OKD: Add authorized keys if missing after ignition #2393

Closed

fortinj66 deleted the update-resolv-prepender branch February 19, 2021 20:57

Conversation

fortinj66 commented Feb 1, 2021

Uh oh!

openshift-ci-robot commented Feb 1, 2021

Uh oh!

Uh oh!

vrutkovs commented Feb 1, 2021

Uh oh!

vrutkovs commented Feb 1, 2021

Uh oh!

openshift-ci-robot commented Feb 1, 2021

Uh oh!

vrutkovs commented Feb 1, 2021

Uh oh!

openshift-ci-robot commented Feb 1, 2021

Uh oh!

kikisdeliveryservice commented Feb 1, 2021

Uh oh!

vrutkovs commented Feb 1, 2021

Uh oh!

vrutkovs commented Feb 1, 2021

Uh oh!

kikisdeliveryservice commented Feb 1, 2021

Uh oh!

fortinj66 commented Feb 1, 2021

Uh oh!

fortinj66 commented Feb 2, 2021

Uh oh!

Uh oh!

Uh oh!

vrutkovs commented Feb 2, 2021

Uh oh!

vrutkovs commented Feb 2, 2021

Uh oh!

mandre left a comment

Choose a reason for hiding this comment

Uh oh!

cybertron commented Feb 2, 2021

Uh oh!

kikisdeliveryservice commented Feb 3, 2021

Uh oh!

openshift-ci-robot commented Feb 3, 2021

Uh oh!

openshift-bot commented Feb 3, 2021

Uh oh!

fortinj66 commented Feb 3, 2021

Uh oh!

vrutkovs commented Feb 3, 2021

Uh oh!

openshift-bot commented Feb 3, 2021

Uh oh!

openshift-bot commented Feb 3, 2021

Uh oh!

openshift-bot commented Feb 3, 2021

Uh oh!

openshift-ci Bot commented Feb 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Feb 4, 2021

Uh oh!

openshift-ci-robot commented Feb 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

openshift-ci Bot commented Feb 4, 2021 •

edited

Loading