Skip to content

Revert disabling authorized_keys.d Pull 2087 #2387

Closed
fortinj66 wants to merge 2 commits intoopenshift:masterfrom
fortinj66:revert-disabling-authorized_keys.d
Closed

Revert disabling authorized_keys.d Pull 2087 #2387
fortinj66 wants to merge 2 commits intoopenshift:masterfrom
fortinj66:revert-disabling-authorized_keys.d

Conversation

@fortinj66
Copy link
Copy Markdown
Contributor

revert #2087
until #2385 is fixed

The authorized_keys file is not being created on cluster install and with authorized_keys.d disabled ssh into the
cluster nodes is not possible without manual intervention. Once that issue is fixed authorized_keys.d can be disabled.

The entry has to be commented out so that the original value does not get overwritten.

Merge from master 2021-02-03
        until #2385 is fixed

the authorized_keys file is not being created on cluster install and and authorized_keys.d is disabled ssh into the
cluster nodes is not possible without manual intervention.  Once that issue is fixed authorized_keys.d can be disabled.
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fortinj66
To complete the pull request process, please assign runcom after the PR has been reviewed.
You can assign the PR to them by writing /assign @runcom in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

Hi @fortinj66. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 3, 2021
Copy link
Copy Markdown
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you clean up the commit, there should only be one.

@fortinj66
Copy link
Copy Markdown
Contributor Author

Yep... I'm not sure why I got two... sigh

@fortinj66
Copy link
Copy Markdown
Contributor Author

extra commit included... closing for #2388

@fortinj66
Copy link
Copy Markdown
Contributor Author

closing for #2388

@fortinj66 fortinj66 closed this Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants