[release-4.6] [vsphere] set hostname with --static to provide consistent node name for CSR approval by openshift-cherrypick-robot · Pull Request #2404 · openshift/machine-config-operator

openshift-cherrypick-robot · 2021-02-11T01:01:23Z

This is an automated cherry-pick of #2380

/assign rvanderp3

openshift-ci-robot · 2021-02-11T01:01:31Z

@openshift-cherrypick-robot: Bugzilla bug 1920807 has been cloned as Bugzilla bug 1927555. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 1927555: [vsphere] set hostname with --static to provide consistent node name for CSR approval

Details

In response to this:

[release-4.6] Bug 1920807: [vsphere] set hostname with --static to provide consistent node name for CSR approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-02-11T01:01:47Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1927555, which is invalid:

expected dependent Bugzilla bug 1920807 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead
expected dependent Bugzilla bug 1920807 to target a release in 4.7.0, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.6] Bug 1927555: [vsphere] set hostname with --static to provide consistent node name for CSR approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rvanderp3 · 2021-02-11T14:13:32Z

/bugzilla refresh

openshift-ci-robot · 2021-02-11T14:13:36Z

@rvanderp3: This pull request references Bugzilla bug 1927555, which is invalid:

expected dependent Bugzilla bug 1927783 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rvanderp3 · 2021-02-11T14:16:31Z

/test e2e-vsphere

rvanderp3 · 2021-02-11T14:25:16Z

/test e2e-agnostic-upgrade

vrutkovs · 2021-02-11T16:47:18Z

/hold

This breaks down OKD as its using vmtoolsd which is not available on OKDs first boot

vrutkovs · 2021-02-11T17:09:48Z

/test vsphere-upi

openshift-ci-robot · 2021-02-11T17:10:00Z

@vrutkovs: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test cluster-bootimages
/test e2e-agnostic-upgrade
/test e2e-aws
/test e2e-aws-disruptive
/test e2e-aws-proxy
/test e2e-aws-workers-rhel7
/test e2e-azure
/test e2e-gcp-op
/test e2e-metal-ipi
/test e2e-openstack
/test e2e-ovirt
/test e2e-ovn-step-registry
/test e2e-vsphere
/test e2e-vsphere-upi
/test images
/test okd-e2e-aws
/test okd-e2e-gcp-op
/test okd-e2e-upgrade
/test okd-e2e-vsphere
/test okd-images
/test unit
/test verify

Use /test all to run the following jobs:

pull-ci-openshift-machine-config-operator-release-4.6-e2e-agnostic-upgrade
pull-ci-openshift-machine-config-operator-release-4.6-e2e-aws
pull-ci-openshift-machine-config-operator-release-4.6-e2e-aws-workers-rhel7
pull-ci-openshift-machine-config-operator-release-4.6-e2e-gcp-op
pull-ci-openshift-machine-config-operator-release-4.6-e2e-metal-ipi
pull-ci-openshift-machine-config-operator-release-4.6-e2e-ovn-step-registry
pull-ci-openshift-machine-config-operator-release-4.6-images
pull-ci-openshift-machine-config-operator-release-4.6-okd-e2e-aws
pull-ci-openshift-machine-config-operator-release-4.6-okd-e2e-gcp-op
pull-ci-openshift-machine-config-operator-release-4.6-okd-e2e-upgrade
pull-ci-openshift-machine-config-operator-release-4.6-okd-images
pull-ci-openshift-machine-config-operator-release-4.6-unit
pull-ci-openshift-machine-config-operator-release-4.6-verify

Details

In response to this:

/test vsphere-upi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vrutkovs · 2021-02-11T17:11:58Z

/test e2e-vsphere-upi

vrutkovs · 2021-02-11T20:48:53Z

Doesn't seem to break vSphere UPI, removing hold

/hold cancel

darkmuggle · 2021-02-11T22:27:29Z

/lgtm

openshift-bot · 2021-02-12T01:00:19Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-12T01:00:22Z

@openshift-bot: This pull request references Bugzilla bug 1927555, which is invalid:

expected dependent Bugzilla bug 1927783 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-13T01:00:15Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-13T01:00:18Z

@openshift-bot: This pull request references Bugzilla bug 1927555, which is invalid:

expected dependent Bugzilla bug 1927783 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-14T01:01:06Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-14T01:01:09Z

@openshift-bot: This pull request references Bugzilla bug 1927555, which is invalid:

expected dependent Bugzilla bug 1927783 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rvanderp3 · 2021-04-01T23:52:23Z

Setting a hold due to related PRs 2490 and 2405 in 4.7. The fix for 2405 will also need to be backported and merged in conjunction with this fix.

/hold

rvanderp3 · 2021-04-12T12:30:42Z

/retest

rvanderp3 · 2021-04-12T14:18:41Z

/test e2e-vsphere

rvanderp3 · 2021-04-12T18:17:12Z

/test e2e-vsphere

rvanderp3 · 2021-04-14T14:42:13Z

/test e2e-vsphere
/test e2e-vsphere-upgrade

rvanderp3 · 2021-04-14T19:18:55Z

/test e2e-vsphere

rvanderp3 · 2021-04-15T00:33:22Z

/test e2e-vsphere

rvanderp3 · 2021-04-15T13:35:01Z

/test e2e-vsphere-upi

rvanderp3 · 2021-04-16T17:03:01Z

Tested with custom release image based on 4.6.0-0.nightly-2021-04-15-161736 which contained both this fix as well as the fix for PR 2490(which will be cherry-picked after this merge). Tests run:

Upgrade which previously would have resulted in node-name loss
Successful scaling of a node which received a DHCP assigned hostname.

jcpowermac · 2021-04-19T16:01:36Z

/lgtm
/approve

yuqi-zhang · 2021-04-19T16:32:15Z

/approve

openshift-ci-robot · 2021-04-19T16:34:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: darkmuggle, jcpowermac, openshift-cherrypick-robot, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rvanderp3 · 2021-05-05T17:03:13Z

/test e2e-vsphere

rvanderp3 · 2021-05-05T18:30:48Z

/test e2e-vsphere

rvanderp3 · 2021-05-13T14:19:37Z

/test e2e-vsphere

rvanderp3 · 2021-06-10T23:38:59Z

/test e2e-vsphere

rvanderp3 · 2021-06-10T23:40:42Z

I am leaving a hold on this pending vSphere e2e testing completing.

rvanderp3 · 2021-06-10T23:44:33Z

/test e2e-vsphere-upi

openshift-ci · 2021-06-11T01:52:59Z

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/okd-e2e-aws	`0b07c94`	link	`/test okd-e2e-aws`
ci/prow/okd-e2e-gcp-op	`0b07c94`	link	`/test okd-e2e-gcp-op`
ci/prow/okd-e2e-upgrade	`0b07c94`	link	`/test okd-e2e-upgrade`
ci/prow/e2e-vsphere-upgrade	`0b07c94`	link	`/test e2e-vsphere-upgrade`
ci/prow/e2e-vsphere	`0b07c94`	link	`/test e2e-vsphere`
ci/prow/e2e-vsphere-upi	`0b07c94`	link	`/test e2e-vsphere-upi`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rvanderp3 · 2021-06-14T20:40:17Z

Replaced with PR 2615. A problem was found(see pr 2490) in release-4.7 which would require a change to this cherry-pick. I recommend closing this PR.

openshift-ci · 2021-06-14T21:02:44Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.6] [vsphere] set hostname with --static to provide consistent node name for CSR approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kikisdeliveryservice · 2021-06-14T21:03:10Z

Removed BZ from title at @rvanderp3 request :)

kikisdeliveryservice · 2021-06-14T21:04:31Z

BZ not on bug, closing PR as requested.

vSphere: Set hostname statically on first boot from VMware configuration

0b07c94

openshift-ci-robot assigned rvanderp3 Feb 11, 2021

openshift-cherrypick-robot mentioned this pull request Feb 11, 2021

Bug 1920807: [vsphere] set hostname with --static to provide consistent node name for CSR approval #2380

Merged

openshift-ci-robot requested review from runcom and yuqi-zhang February 11, 2021 01:01

openshift-ci-robot changed the title ~~[release-4.6] Bug 1920807: [vsphere] set hostname with --static to provide consistent node name for CSR approval~~ [release-4.6] Bug 1927555: [vsphere] set hostname with --static to provide consistent node name for CSR approval Feb 11, 2021

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 11, 2021

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2021

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2021

openshift-ci-robot assigned darkmuggle Feb 11, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2021

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2021

openshift-ci-robot assigned jcpowermac Apr 19, 2021

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2021

kikisdeliveryservice changed the title ~~[release-4.6] Bug 1927555: [vsphere] set hostname with --static to provide consistent node name for CSR approval~~ [release-4.6] [vsphere] set hostname with --static to provide consistent node name for CSR approval Jun 14, 2021

openshift-ci Bot removed bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 14, 2021

kikisdeliveryservice closed this Jun 14, 2021

Conversation

openshift-cherrypick-robot commented Feb 11, 2021

Uh oh!

openshift-ci-robot commented Feb 11, 2021

Uh oh!

openshift-ci-robot commented Feb 11, 2021

Uh oh!

rvanderp3 commented Feb 11, 2021

Uh oh!

openshift-ci-robot commented Feb 11, 2021

Uh oh!

rvanderp3 commented Feb 11, 2021

Uh oh!

rvanderp3 commented Feb 11, 2021

Uh oh!

vrutkovs commented Feb 11, 2021

Uh oh!

vrutkovs commented Feb 11, 2021

Uh oh!

openshift-ci-robot commented Feb 11, 2021

Uh oh!

vrutkovs commented Feb 11, 2021

Uh oh!

vrutkovs commented Feb 11, 2021

Uh oh!

darkmuggle commented Feb 11, 2021

Uh oh!

openshift-bot commented Feb 12, 2021

Uh oh!

openshift-ci-robot commented Feb 12, 2021

Uh oh!

openshift-bot commented Feb 13, 2021

Uh oh!

openshift-ci-robot commented Feb 13, 2021

Uh oh!

openshift-bot commented Feb 14, 2021

Uh oh!

openshift-ci-robot commented Feb 14, 2021

Uh oh!

rvanderp3 commented Apr 1, 2021

Uh oh!

rvanderp3 commented Apr 12, 2021

Uh oh!

rvanderp3 commented Apr 12, 2021

Uh oh!

rvanderp3 commented Apr 12, 2021

Uh oh!

rvanderp3 commented Apr 14, 2021

Uh oh!

rvanderp3 commented Apr 14, 2021

Uh oh!

rvanderp3 commented Apr 15, 2021

Uh oh!

rvanderp3 commented Apr 15, 2021

Uh oh!

rvanderp3 commented Apr 16, 2021

Uh oh!

jcpowermac commented Apr 19, 2021

Uh oh!

yuqi-zhang commented Apr 19, 2021

Uh oh!

openshift-ci-robot commented Apr 19, 2021

Uh oh!

rvanderp3 commented May 5, 2021

Uh oh!

rvanderp3 commented May 5, 2021

Uh oh!

rvanderp3 commented May 13, 2021

Uh oh!

rvanderp3 commented Jun 10, 2021

Uh oh!

rvanderp3 commented Jun 10, 2021

Uh oh!

rvanderp3 commented Jun 10, 2021

Uh oh!

openshift-ci Bot commented Jun 11, 2021

Uh oh!

rvanderp3 commented Jun 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rvanderp3 commented Jun 14, 2021 •

edited

Loading