Remove platform-specific Corefile templates#2410
Remove platform-specific Corefile templates#2410cybertron wants to merge 1 commit intoopenshift:masterfrom
Conversation
As far as I can tell, these are all providing the exact same records, just using variations on the specific plugin. For the sake of simplicity, let's converge on one Corefile template. A couple of notes: 1) I used the on-prem one because it handles ipv4 and ipv6 records in an RFC-compliant way, which none of the other plugins do. 2) I left the kubevirt db file. I'm not sure why it's there since there doesn't seem to be a corresponding Corefile for the platform, and since I don't understand it I think it's safest to leave it alone.
|
/test e2e-openstack |
|
/retest metal-ipi failed to deploy the masters before this ever would come into play (and shouldn't be affected by this change anyway), openstack and vsphere both appear to have successfully deployed the nodes and failed on other things, which means coredns should be working. Unfortunately my must-gather patch hasn't merged yet so we don't have logs from the infra containers there yet. |
|
/test e2e-openstack |
|
@eslutsky can you please review this change ? |
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
LGTM for OpenStack.
OpenStack was able to deploy the cluster which indicates DNS is working as expected. The job failed on an unrelated monitoring alert.
|
FYI: we now have owners files for template dirs so y'all will need to actually approve =) |
Great! in that case, /lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cybertron, mandre The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest C'mon openstack, you can do it! :-) |
|
/test e2e-openstack |
|
/retest |
1 similar comment
|
/retest |
|
FYI I'm moving openstack job to a more stable platform with openshift/release#16936 |
|
/retest Looks like the openstack patch merged, so let's see if we have better luck now. |
|
/test e2e-openstack |
Sadly we experienced our first issue with Vexxhost right after we moved the openstack job there. It is fixed now. /test e2e-openstack |
|
/test e2e-openstack Failed to bootstrap. Since bootstrapping is no longer dependent on DNS, I doubt it's related. |
|
This went in as part of #2465 . |
6 participants
As far as I can tell, these are all providing the exact same records,
just using variations on the specific plugin. For the sake of simplicity,
let's converge on one Corefile template.
A couple of notes:
in an RFC-compliant way, which none of the other plugins do.
there doesn't seem to be a corresponding Corefile for the platform,
and since I don't understand it I think it's safest to leave it
alone.
- What I did
- How to verify it
- Description for the changelog