Remove coredns from on-prem platforms#2450
Remove coredns from on-prem platforms#2450cybertron wants to merge 1 commit intoopenshift:masterfrom
Conversation
The only thing we have to use coredns for at this point is node name resolution, and it turns out we don't actually need that anymore. The internal records it provides can be just as easily provided by dnsmasq running on the host and then we don't have to deploy and manage an extra pod with its attendant init and monitor containers. It also means we can remove the mdns-publisher pod.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cybertron The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
cybertron
left a comment
cybertron
left a comment
There was a problem hiding this comment.
/hold
This should probably wait on the outcome of openshift/enhancements#654 as it's making a lot of the same architectural changes as that enhancement.
| @@ -0,0 +1,10 @@ | |||
| name: on-prem-dnsmasq.service | |||
There was a problem hiding this comment.
I'm not sure we actually need a separate service for this now that it's being run as vanilla dnsmasq. I'm also not sure if there's a simple way to enable an existing OS service using MCO. I'm open to suggestions.
There was a problem hiding this comment.
I would prefet to have a separate service or a systemctl override of the default one.
openshift-ci-robot
added
the
do-not-merge/hold
|
/test e2e-metal-ipi |
|
@cybertron: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
Bot
added
lifecycle/stale
|
@cybertron: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
Bot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
The only thing we have to use coredns for at this point is node
name resolution, and it turns out we don't actually need that anymore.
The internal records it provides can be just as easily provided by
dnsmasq running on the host and then we don't have to deploy and
manage an extra pod with its attendant init and monitor containers.
It also means we can remove the mdns-publisher pod.
- What I did
- How to verify it
- Description for the changelog