Skip to content

Bug 1941246: vSphere: Disable tx udp_csum segmentation#2475

Closed
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.7from
openshift-cherrypick-robot:cherry-pick-2472-to-release-4.7
Closed

Bug 1941246: vSphere: Disable tx udp_csum segmentation#2475
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.7from
openshift-cherrypick-robot:cherry-pick-2472-to-release-4.7

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #2472

/assign wking

Based on one of VMware's recommendations disable
both:

tx-udp_tnl-segmentation
tx-udp_tnl-csum-segmentation

This could potentially replace the more generic offload disable.
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1935539 has been cloned as Bugzilla bug 1941246. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1941246: vSphere: Disable tx udp_csum segmentation

Details

In response to this:

[release-4.7] Bug 1935539: vSphere: Disable tx udp_csum segmentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.7] Bug 1935539: vSphere: Disable tx udp_csum segmentation [release-4.7] Bug 1941246: vSphere: Disable tx udp_csum segmentation Mar 21, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Mar 21, 2021
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1941246, which is invalid:

  • expected dependent Bugzilla bug 1935539 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.7] Bug 1941246: vSphere: Disable tx udp_csum segmentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 21, 2021
@wking
Copy link
Copy Markdown
Member

wking commented Mar 21, 2021

GitHub stores the release-4.7 base as structured metadata, so no need to hold it in the title:

/retitle Bug 1941246: vSphere: Disable tx udp_csum segmentation

@openshift-ci-robot openshift-ci-robot changed the title [release-4.7] Bug 1941246: vSphere: Disable tx udp_csum segmentation Bug 1941246: vSphere: Disable tx udp_csum segmentation Mar 21, 2021
@vikaslaad
Copy link
Copy Markdown

/retest

3 similar comments
@vikaslaad
Copy link
Copy Markdown

/retest

@vikaslaad
Copy link
Copy Markdown

/retest

@vikaslaad
Copy link
Copy Markdown

/retest

@jcpowermac
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 22, 2021
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@vikaslaad
Copy link
Copy Markdown

/retest

@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 22, 2021
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@openshift-bot: This pull request references Bugzilla bug 1941246, which is invalid:

  • expected dependent Bugzilla bug 1935539 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhaozhanqi
Copy link
Copy Markdown

I guess this PR should be closed due to a new PR #2482 changed
cc @jcpowermac

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jcpowermac
Copy link
Copy Markdown
Contributor

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 23, 2021

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-assisted 886ef27 link /test e2e-metal-assisted
ci/prow/okd-e2e-gcp-op 886ef27 link /test okd-e2e-gcp-op

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcpowermac
Copy link
Copy Markdown
Contributor

nmcli seems to require the interface to be reset until it applies the ethtool setting. This didn't work while I was testing yesterday. Another in-flight PR: #2482
I tested this solution on a master that the upgrade failed on. Correctly turned off the nic features.

Currently testing an upgrade from 4.6 to 4.7.3 (including the changes to MCO) with release image: quay.io/jcallen/origin-release@sha256:18c1e2c43503292b21dc9b32c66970a3891ddc3f242650f6ab2597c7b2c12d58

@jcpowermac
Copy link
Copy Markdown
Contributor

/close

This will be replaced with cherry-pick of #2482

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@jcpowermac: Closed this PR.

Details

In response to this:

/close

This will be replaced with cherry-pick of #2482

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1941246. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

Bug 1941246: vSphere: Disable tx udp_csum segmentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants