Skip to content

Bug 1949818: test/e2e: add e2e test for Single Node OpenShift#2507

Merged
openshift-merge-robot merged 2 commits into
openshift:masterfrom
sinnykumari:e2e-gcp-op-sno
Apr 20, 2021
Merged

Bug 1949818: test/e2e: add e2e test for Single Node OpenShift#2507
openshift-merge-robot merged 2 commits into
openshift:masterfrom
sinnykumari:e2e-gcp-op-sno

Conversation

@sinnykumari
Copy link
Copy Markdown
Contributor

Also, refactor existing e2e test so that common functionalities
can be shared between both SNO and regular cluster

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2021
@sinnykumari
Copy link
Copy Markdown
Contributor Author

Require openshift/release#17357

@sinnykumari
Copy link
Copy Markdown
Contributor Author

/retest

@sinnykumari sinnykumari changed the title [WIP] test/e2e: add e2e test for Single Node OpenShift test/e2e: add e2e test for Single Node OpenShift Apr 1, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2021
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@sinnykumari: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2021
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2021
@sinnykumari
Copy link
Copy Markdown
Contributor Author

Rebased and fixed merge conflict

@yuqi-zhang
Copy link
Copy Markdown
Contributor

Did a first pass and the general code lgtm. Quick question, when you say:

Require openshift/release#17357

Does't 17357 require this to merge first such that it can run make test-e2e-single-node? Or am I misunderstanding the comment and that's what you meant?

@sinnykumari
Copy link
Copy Markdown
Contributor Author

Did a first pass and the general code lgtm. Quick question, when you say:

Require openshift/release#17357

Does't 17357 require this to merge first such that it can run make test-e2e-single-node? Or am I misunderstanding the comment and that's what you meant?

No, openshift/release#17357 needs to merge first so that e2e-gcp-op-single-node job gets created and we can start a job on this PR with something like /test e2e-gcp-op-single-node

@sinnykumari
Copy link
Copy Markdown
Contributor Author

/retest

@sinnykumari
Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-op-single-node

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@sinnykumari: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test cluster-bootimages
  • /test e2e-agnostic-upgrade
  • /test e2e-aws
  • /test e2e-aws-disruptive
  • /test e2e-aws-proxy
  • /test e2e-aws-serial
  • /test e2e-aws-single-node
  • /test e2e-aws-workers-rhel7
  • /test e2e-azure
  • /test e2e-gcp-op
  • /test e2e-gcp-single-node
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-openstack
  • /test e2e-ovirt
  • /test e2e-ovn-step-registry
  • /test e2e-vsphere
  • /test e2e-vsphere-upgrade
  • /test e2e-vsphere-upi
  • /test images
  • /test okd-e2e-aws
  • /test okd-e2e-gcp-op
  • /test okd-e2e-upgrade
  • /test okd-e2e-vsphere
  • /test okd-images
  • /test unit
  • /test verify

Use /test all to run the following jobs:

  • pull-ci-openshift-machine-config-operator-master-e2e-agnostic-upgrade
  • pull-ci-openshift-machine-config-operator-master-e2e-aws
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-disruptive
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-serial
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-workers-rhel7
  • pull-ci-openshift-machine-config-operator-master-e2e-gcp-op
  • pull-ci-openshift-machine-config-operator-master-e2e-metal-ipi
  • pull-ci-openshift-machine-config-operator-master-e2e-ovn-step-registry
  • pull-ci-openshift-machine-config-operator-master-e2e-vsphere-upgrade
  • pull-ci-openshift-machine-config-operator-master-images
  • pull-ci-openshift-machine-config-operator-master-okd-e2e-aws
  • pull-ci-openshift-machine-config-operator-master-okd-images
  • pull-ci-openshift-machine-config-operator-master-unit
  • pull-ci-openshift-machine-config-operator-master-verify
Details

In response to this:

/test e2e-gcp-op-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

/test e2e-gcp-op-single-node

@sinnykumari
Copy link
Copy Markdown
Contributor Author

There is a known issue that on Single Node OpenShift, load is too high for any pod to be deployed when RT kernel profile is being used. As a result, MCO operation gets impacted and are very slow causing our further ci tests to fail like rollback of RT kernel. This is because when we are perform rollback operation, RHCOS node is booted into RT kernel. Corresponding bug: https://bugzilla.redhat.com/show_bug.cgi?id=1939133 .

I have moved RealTime kernel test as last test and removed rollback. We can add rollback test once bug#1939133 has been fixed or we have resources in ci to run SNO that is optimized for RT kernel.

@sinnykumari
Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-op-single-node

@sinnykumari sinnykumari changed the title test/e2e: add e2e test for Single Node OpenShift Bug 1949818: test/e2e: add e2e test for Single Node OpenShift Apr 15, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Apr 15, 2021
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@sinnykumari: This pull request references Bugzilla bug 1949818, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1949818: test/e2e: add e2e test for Single Node OpenShift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 15, 2021
@sinnykumari
Copy link
Copy Markdown
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@sinnykumari: This pull request references Bugzilla bug 1949818, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @mike-nguyen

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 15, 2021
@sinnykumari
Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-op-single-node

@sinnykumari
Copy link
Copy Markdown
Contributor Author

Hmm, from the log e2e-gcp-op-single-node succeeded:

 INFO[2021-04-15T12:42:23Z] Running step e2e-gcp-op-single-node-test.    
INFO[2021-04-15T14:03:44Z] Step e2e-gcp-op-single-node-test succeeded after 1h21m20.061125104s.

But, gathering must-gather logs failed. Looks like having RT kernel installed on node is making node cry for resources. I am going to completely remove TestKernelType test until https://bugzilla.redhat.com/show_bug.cgi?id=1939133 is resolved.

Also, refactor existing e2e test so that common functionalities
can be shared between both SNO and regular cluster

We will include kernelType test once
https://bugzilla.redhat.com/show_bug.cgi?id=1939133 has been resolved
@sinnykumari
Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-op-single-node

@sinnykumari
Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@sinnykumari
Copy link
Copy Markdown
Contributor Author

/retest

@sinnykumari
Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-op-single-node

@sinnykumari
Copy link
Copy Markdown
Contributor Author

Finally, e2e-gcp-op-single-node is green 🎉
@yuqi-zhang @kikisdeliveryservice should be good to go now.

@yuqi-zhang
Copy link
Copy Markdown
Contributor

/lgtm

Looks great! Thanks for working on this!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2021
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sinnykumari, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [sinnykumari,yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 20, 2021

@sinnykumari: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere-upgrade 9c2b4ef link /test e2e-vsphere-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sinnykumari
Copy link
Copy Markdown
Contributor Author

/test e2e-agnostic-upgrade

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d3da910 into openshift:master Apr 20, 2021
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@sinnykumari: All pull requests linked via external trackers have merged:

Bugzilla bug 1949818 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1949818: test/e2e: add e2e test for Single Node OpenShift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants