add kubelet skew check for MCO upgradeable#2552
Conversation
openshift-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I'm likely biased but some recent reports of difficulty, but explicit expectations seems better than implicit expectations. I can't even think of a place where we'd need a valid override (but there very well could be one). |
| // don't overwrite status if we didn't run | ||
| if ran, err := optr.isKubeletSkewTooFar(); ran && err != nil { | ||
| if coStatus.Status != configv1.ConditionFalse { | ||
| coStatus.Status = configv1.ConditionFalse |
There was a problem hiding this comment.
I'd still love a coStatus.DocumentationLink type field here for these use-cases, but I knw that's a bigger change ;)
@deads2k what do you mean |
|
this is being worked on via another pr closing as it's unneeded. |
5 participants
Implementation of openshift/enhancements#762 with locality at the point of action.
Produces a condition like
KubeletSkewTooFar node/first-node must be updated or removed before the cluster can upgrade, current version v1.18/hold just a POC demonstrating ease and benefits of locality.
cc @crawford @rphillips